ci: Enhance sanitizer's config #603
Conversation
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 64 64
Lines 9432 9432
=======================================
Hits 9268 9268
Misses 164 164 |
chfast
force-pushed
the
ci_sanitizers
branch
2 times, most recently
from
e31e0ad
to
0c441d7
Compare
chfast
changed the title
| UBSAN_OPTIONS: halt_on_error=1 | ||
| steps: | ||
| - install_testfloat | ||
| - checkout | ||
| - build: | ||
| build_type: RelWithDebInfo | ||
| # TODO: pointer-compare produces failure in std::string operator+. |
There was a problem hiding this comment.
This didn't even use pointer-compare, but I see you removed pointer-subtract -- perhaps that should be removed in the first commit?
There was a problem hiding this comment.
It seem it only removed the comment and not the line below?
| @@ -595,10 +591,10 @@ jobs: | |||
| rustup toolchain install nightly-x86_64-unknown-linux-gnu | |||
| - run: | |||
| name: Build (debug mode) | |||
| command: RUSTFLAGS="-Z sanitizer=address" ASAN_OPTIONS=detect_leaks=1 cargo +nightly build --target x86_64-unknown-linux-gnu | |||
There was a problem hiding this comment.
Ok since this on by default on Linux (not on MacOS): https://clang.llvm.org/docs/AddressSanitizer.html#memory-leak-detection
| @@ -595,10 +591,10 @@ jobs: | |||
| rustup toolchain install nightly-x86_64-unknown-linux-gnu | |||
| - run: | |||
| name: Build (debug mode) | |||
| command: RUSTFLAGS="-Z sanitizer=address" ASAN_OPTIONS=detect_leaks=1 cargo +nightly build --target x86_64-unknown-linux-gnu | |||
| command: RUSTFLAGS="-Z sanitizer=address" cargo +nightly build --target x86_64-unknown-linux-gnu | |||
There was a problem hiding this comment.
Does asan does anything at compile time? If not we can remove this step.
There was a problem hiding this comment.
Apparently it does some compile-thing things too: rust-lang/rust#45220
Any we should also pass on sanitize mode to cmake: https://users.rust-lang.org/t/sanitizers-in-mixed-rust-and-c-code/48863/4
There was a problem hiding this comment.
You should be building fizzy with -DSANITIZE=address.
chfast
force-pushed
the
ci_sanitizers
branch
2 times, most recently
from
d6ede7e
to
0e3296a
Compare
No description provided.