Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with libc++, C++20 #597

Merged
merged 8 commits into from
Oct 13, 2020
Merged

Build with libc++, C++20 #597

merged 8 commits into from
Oct 13, 2020

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Oct 13, 2020 •
edited
Loading

  • Adds support for building with libc++ on linux by using CMake toolchain file.
  • Upgrades C++20 CI job to clang-11, libc++-11 from clang-10, libstdc++.
  • Fixes some new clang-tidy issues.

@codecov
Copy link

codecov bot commented Oct 13, 2020 •
edited
Loading

Codecov Report

Merging #597 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files          63       63           
  Lines        9224     9224           
=======================================
  Hits         9063     9063           
  Misses        161      161

chfast
chfast commented Oct 13, 2020
View reviewed changes
CMakeLists.txt
-Wno-return-std-move-in-c++11
-Wno-switch-enum
)
if(CMAKE_CXX_COMPILER_ID MATCHES Clang)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated. I originally thought that I will add -DLIBCXX option here, but turned out toolchain file is needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what about this change then?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is correct because -Weverything makes sense only for Clang.

@chfast chfast marked this pull request as ready for review October 13, 2020 14:07
@chfast chfast requested review from axic and gumb0 October 13, 2020 14:07
@chfast chfast changed the title Build with libc++ Build with libc++, C++20 Oct 13, 2020
@chfast
Copy link
Collaborator Author

chfast commented Oct 13, 2020 

fizzy/execute/blake2b/512_bytes_rounds_1_mean                     +0.0235         +0.0235            87            89            87            89
fizzy/execute/blake2b/512_bytes_rounds_16_mean                    +0.0203         +0.0203          1316          1343          1316          1343
fizzy/execute/ecpairing/onepoint_mean                             +0.0072         +0.0072        410735        413699        410738        413705
fizzy/execute/keccak256/512_bytes_rounds_1_mean                   +0.0951         +0.0951           101           111           101           111
fizzy/execute/keccak256/512_bytes_rounds_16_mean                  +0.0842         +0.0842          1503          1629          1503          1629
fizzy/execute/memset/256_bytes_mean                               +0.0068         +0.0068             7             7             7             7
fizzy/execute/memset/60000_bytes_mean                             +0.0073         +0.0073          1599          1610          1599          1610
fizzy/execute/mul256_opt0/input1_mean                             -0.0061         -0.0061            29            28            29            28
fizzy/execute/ramanujan_pi/33_runs_mean                           +0.1152         +0.1152           131           146           131           146
fizzy/execute/sha1/512_bytes_rounds_1_mean                        -0.0025         -0.0025            94            94            94            94
fizzy/execute/sha1/512_bytes_rounds_16_mean                       -0.0062         -0.0062          1314          1305          1314          1306
fizzy/execute/sha256/512_bytes_rounds_1_mean                      -0.0689         -0.0689           100            93           100            93
fizzy/execute/sha256/512_bytes_rounds_16_mean                     -0.0676         -0.0676          1367          1275          1367          1275
fizzy/execute/taylor_pi/pi_1000000_runs_mean                      +0.1501         +0.1501         40540         46627         40541         46627
fizzy/execute/micro/eli_interpreter/exec105_mean                  +0.0389         +0.0389             5             5             5             5
fizzy/execute/micro/factorial/20_mean                             -0.0605         -0.0605             1             1             1             1
fizzy/execute/micro/fibonacci/24_mean                             -0.0302         -0.0302          5230          5072          5230          5072
fizzy/execute/micro/host_adler32/1_mean                           +0.0079         +0.0079             0             0             0             0
fizzy/execute/micro/host_adler32/1000_mean                        +0.0348         +0.0348            29            31            29            31
fizzy/execute/micro/spinner/1_mean                                -0.0512         -0.0512             0             0             0             0
fizzy/execute/micro/spinner/1000_mean                             +0.0480         +0.0480            10            11            10            11

@chfast chfast merged commit 9efe556 into master Oct 13, 2020
@chfast chfast deleted the libcxx branch October 13, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gumb0 gumb0 gumb0 approved these changes

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfast @axic @gumb0