Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: add simple compilation (integration) test #588

Closed
wants to merge 4 commits into from

Conversation

axic
Copy link
Member

@axic axic commented Oct 6, 2020

No description provided.

@axic axic requested review from chfast and gumb0 October 6, 2020 18:04
Copy link
Collaborator

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but should rather go to somewhere in test/

@axic
Copy link
Member Author

axic commented Oct 6, 2020

Looks fine, but should rather go to somewhere in test/

I was wondering about that. Right now test is strictly C/C++. Once we have Go bindings, would tests of it go there too? Is it feasible with Go? Would any of this conflict with the cmake/gtest stuff?

@chfast
Copy link
Collaborator

chfast commented Oct 6, 2020

Looks fine, but should rather go to somewhere in test/

I was wondering about that. Right now test is strictly C/C++. Once we have Go bindings, would tests of it go there too? Is it feasible with Go? Would any of this conflict with the cmake/gtest stuff?

Unittest should be placed by the given language convention. But this is rather integration test, so I'd rather put in test/rust_compilation or bindings/rust/test/.

@axic
Copy link
Member Author

axic commented Oct 6, 2020

Apparently can't move to test/rust-compilation, because it expects test to be a cargo directory for some reason:

$ cargo build
error: failed to read `/Users/alex/Projects/fizzy/test/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

@axic axic force-pushed the rust-compliation-test branch from a92fe3d to e089245 Compare October 6, 2020 20:07
@chfast
Copy link
Collaborator

chfast commented Oct 7, 2020

Apparently can't move to test/rust-compilation, because it expects test to be a cargo directory for some reason:

So binndings/rust/test if that works, otherwise it can stay as it is.

@axic axic force-pushed the rust-compliation-test branch from e089245 to ff60742 Compare October 7, 2020 09:10
@axic
Copy link
Member Author

axic commented Oct 7, 2020

Replaced by #591. The branch name had a typo here.

@axic axic closed this Oct 7, 2020
@axic axic deleted the rust-compliation-test branch October 7, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants