Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run Rust build in release mode too #586

Merged
merged 1 commit into from
Oct 6, 2020
Merged

ci: run Rust build in release mode too #586

merged 1 commit into from
Oct 6, 2020

Conversation

axic
Copy link
Member

@axic axic commented Oct 6, 2020

cargo build will build Fizzy in Debug profile, while cargo build --release will do with Release in cmake, see https://docs.rs/cmake/0.1.44/cmake/struct.Config.html#method.profile. The more specific translation rules can be seen in https://docs.rs/cmake/0.1.44/src/cmake/lib.rs.html#553-558 (it can use Release, RelWithDebInfo, MinSizeRel depending on settings).

We could also decide to force Release mode if we want.

Furthermore it seems PIC is used in both modes, we may want to investigate this (see https://docs.rs/cmake/0.1.44/cmake/struct.Config.html#method.pic).

Copy link
Collaborator

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more specific translation rules can be seen in https://docs.rs/cmake/0.1.44/src/cmake/lib.rs.html#553-558 (it can use Release, RelWithDebInfo, MinSizeRel depending on settings).

These look good.

Furthermore it seems PIC is used in both modes, we may want to investigate this (see https://docs.rs/cmake/0.1.44/cmake/struct.Config.html#method.pic).

I can benchmark PIC builds some day.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #586 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          62       62           
  Lines        8990     8990           
=======================================
  Hits         8831     8831           
  Misses        159      159           

@axic axic merged commit e8eae59 into master Oct 6, 2020
@axic axic deleted the rust-ci branch October 6, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants