bench: add FizzyCEngine #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
fizzy_c_engine
branch
from
ea47ca0 to
356c5ee
Compare
gumb0
force-pushed
the
capi_execute
branch
2 times, most recently
from
6871e47 to
c517410
Compare
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 98.24% 98.25% +0.01%
==========================================
Files 63 64 +1
Lines 9370 9425 +55
==========================================
+ Hits 9206 9261 +55
Misses 164 164 |
gumb0
force-pushed
the
capi_execute
branch
2 times, most recently
from
dfdbfbf to
6525b9d
Compare
gumb0
changed the base branch from
capi_execute
to
capi-execute-dynamic-module
gumb0
force-pushed
the
fizzy_c_engine
branch
3 times, most recently
from
ded8136 to
17f123a
Compare
gumb0
changed the base branch from
capi-execute-dynamic-module
to
capi-instance-memory
gumb0
force-pushed
the
fizzy_c_engine
branch
2 times, most recently
from
79b8a72 to
6a190e6
Compare
gumb0
force-pushed
the
capi-instance-memory
branch
from
b6eea83 to
0a80dfc
Compare
gumb0
force-pushed
the
fizzy_c_engine
branch
3 times, most recently
from
085143c to
f3ab3df
Compare
gumb0
force-pushed
the
capi-instance-memory
branch
from
0a80dfc to
486219a
Compare
gumb0
force-pushed
the
capi-instance-memory
branch
2 times, most recently
from
bed7b06 to
7bf49d1
Compare
axic
reviewed
Oct 12, 2020
axic
approved these changes
Oct 13, 2020
gumb0
force-pushed
the
capi-instance-memory
branch
2 times, most recently
from
66c71d0 to
9791ba5
Compare
gumb0
force-pushed
the
capi-instance-memory
branch
5 times, most recently
from
b7af6f9 to
34bcd69
Compare
gumb0
changed the base branch from
capi-instance-memory
to
capi-resolve-instantiate
axic
reviewed
Oct 15, 2020
test/utils/fizzy_c_engine.cpp
Outdated
| if (!fizzy_find_exported_function( | ||
| fizzy_get_instance_module(m_instance.get()), std::string{name}.c_str(), &func_idx)) | ||
| { | ||
| // TODO check function type |
There was a problem hiding this comment.
Do we have this solved by the API?
There was a problem hiding this comment.
No, it's the same as in C++ API.
There was a problem hiding this comment.
fizzy_engine.cpp does check the signature.
There was a problem hiding this comment.
But i think we can ignore that because we decided to do it only once in fizzy_engine and ignore the other implementaitons.
There was a problem hiding this comment.
I thought to reuse the code from fizzy_engine,cpp, shoud I just remove TODO?
There was a problem hiding this comment.
Yeah, I think it is enough having it in one engine.
gumb0
force-pushed
the
fizzy_c_engine
branch
2 times, most recently
from
d32ba10 to
0b71661
Compare
|
Comparing fizzy vs fizzyc |
This is the only benchmark which should be affected and 6% does not seem to be terrible, but wonder if it can be improved or if this is just noise. Anyway we should handle it outside of this PR. |
gumb0
force-pushed
the
fizzy_c_engine
branch
2 times, most recently
from
50db6d6 to
102f3e3
Compare
axic
approved these changes
Oct 15, 2020
chfast
approved these changes
Oct 16, 2020
test/utils/fizzy_c_engine.cpp
Outdated
| @@ -0,0 +1,121 @@ | |||
| // Fizzy: A fast WebAssembly interpreter | |||
| // Copyright 2019-2020 The Fizzy Authors. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2019-2020 The Fizzy Authors. | |
| // Copyright 2020 The Fizzy Authors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.