C API function type #557

gumb0 · 2020-09-28T14:47:28Z

No description provided.

codecov · 2020-09-28T15:05:56Z

Codecov Report

Merging #557 into master will decrease coverage by 0.00%.
The diff coverage is 96.82%.

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
- Coverage   98.26%   98.26%   -0.01%     
==========================================
  Files          63       63              
  Lines        9238     9282      +44     
==========================================
+ Hits         9078     9121      +43     
- Misses        160      161       +1

gumb0 · 2020-09-30T11:52:10Z

lib/fizzy/capi.cpp

+
+inline fizzy::FuncType unwrap(const FizzyFunctionType& type)
+{
+    fizzy::FuncType func_type{std::vector<fizzy::ValType>(type.inputs_size),


We could optimize it later on the C++ side to not require vector allocation to pass function type (i.e. replace vector with span in fizzy::FuncType)

gumb0 · 2020-10-13T10:21:19Z

lib/fizzy/capi.cpp

@@ -108,25 +145,20 @@ void fizzy_free_module(const FizzyModule* module)
    delete unwrap(module);
 }

+FizzyFunctionType fizzy_get_function_type(const FizzyModule* module, uint32_t func_idx)
+{
+    return wrap(unwrap(module)->get_function_type(func_idx));


Note: get_function_type returns reference to fizzy::FuncType stored in module, then wrap returns pointers to its vector's data.

gumb0 · 2020-10-13T15:04:43Z

static const
The global const means static const in C++, but not in C. This will make them equal.

This will create their copies in each translation unit that includes fizzy.h, is this what we want?

chfast · 2020-10-13T15:17:26Z

This will create their copies in each translation unit that includes fizzy.h, is this what we want?

They are going to be used as compile-time constants, unlikely to be emitted at all.

axic · 2020-10-14T09:06:17Z

@gumb0 can you please rebase and squash?

gumb0 · 2020-10-14T10:13:42Z

@gumb0 can you please rebase and squash?

Done, squashed the last commit.

chfast · 2020-10-14T11:07:00Z

include/fizzy/fizzy.h

+    /// Input types array size.
+    size_t inputs_size;
+    /// Pointer to output types array.
+    const FizzyValueType* outputs;


This is ok, but also can be greatly simplified by defining FizzyValueTypeVoid and using FizzyValueType output_type.

Good idea, I'll try it.

Move it to the front.

gumb0 · 2020-10-14T11:42:21Z

include/fizzy/fizzy.h

+static const FizzyValueType FizzyValueTypeF32 = 0x7d;
+static const FizzyValueType FizzyValueTypeF64 = 0x7c;
+/// Special value, can be used only as function outuput type.
+static const FizzyValueType FizzyValueTypeVoid = 0;


Defining it as 0 allows user to create void type with no params as {}, at least in C++, probably in C, too.

axic · 2020-10-14T16:22:31Z

include/fizzy/fizzy.h

+/// Function type.
+typedef struct FizzyFunctionType
+{
+    /// Output type, can be FizzyValueTypeVoid, if function has no output.


Suggested change

/// Output type, can be FizzyValueTypeVoid, if function has no output.

/// Output type, equals to FizzyValueTypeVoid, if function has no output.

axic · 2020-10-14T16:23:04Z

include/fizzy/fizzy.h

+///                 defined in module.
+///
+/// @note All module function indices are greater than all imported function indices.
+FizzyFunctionType fizzy_get_function_type(const FizzyModule* module, uint32_t func_idx);


What happens on invalid index?

Added a sentence.

axic · 2020-10-14T16:24:20Z

Needs rebase.

gumb0 · 2020-10-14T16:38:41Z

Rebased.

axic · 2020-10-14T16:54:10Z

include/fizzy/fizzy.h

+///
+/// @param module   Pointer to module.
+/// @param func_idx Function index. Can be either index of an imported function or of a function
+///                 defined in module. Behaviour is undefined, index is not valid according to


Suggested change

/// defined in module. Behaviour is undefined, index is not valid according to

/// defined in module. Behaviour is undefined if index is not valid according to

axic

Looks okayish to me.

gumb0 force-pushed the capi_func_type branch 3 times, most recently from 5cd07b1 to 9c3ee98 Compare September 28, 2020 14:54

gumb0 force-pushed the capi_func_type branch from 9c3ee98 to 04f67e6 Compare September 29, 2020 11:18

gumb0 force-pushed the capi_execute branch from 5abcffc to 9ef4767 Compare September 29, 2020 11:28

gumb0 force-pushed the capi_func_type branch 2 times, most recently from 2012ccf to baa54bc Compare September 29, 2020 12:10

gumb0 force-pushed the capi_execute branch from 9ef4767 to 2d7304c Compare September 29, 2020 14:08

gumb0 force-pushed the capi_func_type branch from baa54bc to 7f57cea Compare September 29, 2020 14:19

gumb0 force-pushed the capi_execute branch from 2d7304c to a9b4164 Compare September 29, 2020 16:18

gumb0 force-pushed the capi_func_type branch from 7f57cea to 0e2ac03 Compare September 29, 2020 16:48

gumb0 mentioned this pull request Sep 29, 2020

Public C API #558

Open

49 tasks

gumb0 force-pushed the capi_func_type branch from 0e2ac03 to e94168c Compare September 30, 2020 10:34

gumb0 commented Sep 30, 2020

View reviewed changes

gumb0 force-pushed the capi_func_type branch 3 times, most recently from 9ac35b0 to c0dc40d Compare September 30, 2020 13:24

gumb0 force-pushed the capi_execute branch from a9b4164 to c14d1d9 Compare September 30, 2020 13:33

gumb0 force-pushed the capi_func_type branch 3 times, most recently from 487bc44 to 963dbba Compare September 30, 2020 15:54

axic force-pushed the capi_execute branch from c14d1d9 to d44b309 Compare September 30, 2020 18:56

gumb0 force-pushed the capi_execute branch 2 times, most recently from 6871e47 to c517410 Compare October 1, 2020 13:05

axic force-pushed the capi_execute branch from c517410 to 815497a Compare October 1, 2020 13:47

gumb0 force-pushed the capi_execute branch 2 times, most recently from dfdbfbf to 6525b9d Compare October 5, 2020 11:17

gumb0 force-pushed the capi_func_type branch from 963dbba to 4475d22 Compare October 6, 2020 18:07

gumb0 commented Oct 13, 2020

View reviewed changes

gumb0 force-pushed the capi_func_type branch from 2cbdfc5 to 553a6ea Compare October 13, 2020 10:51

gumb0 marked this pull request as ready for review October 13, 2020 10:52

gumb0 requested review from chfast and axic October 13, 2020 10:59

gumb0 force-pushed the capi_func_type branch from 4cbb1fa to 0e396fe Compare October 13, 2020 15:30

gumb0 force-pushed the capi_func_type branch from 0e396fe to 87e998e Compare October 14, 2020 09:31

chfast reviewed Oct 14, 2020

View reviewed changes

gumb0 commented Oct 14, 2020

View reviewed changes

gumb0 force-pushed the capi_func_type branch from 2f02f4f to 1a20b78 Compare October 14, 2020 14:23

axic reviewed Oct 14, 2020

View reviewed changes

gumb0 force-pushed the capi_func_type branch from 1a20b78 to 375cdc4 Compare October 14, 2020 16:38

gumb0 force-pushed the capi_func_type branch 2 times, most recently from 95246c5 to 9991225 Compare October 14, 2020 16:46

axic reviewed Oct 14, 2020

View reviewed changes

capi: Add FizzyFunctionType and fizzy_get_function_type

3ff631f

gumb0 force-pushed the capi_func_type branch from 9991225 to 3ff631f Compare October 14, 2020 17:38

axic approved these changes Oct 14, 2020

View reviewed changes

chfast approved these changes Oct 15, 2020

View reviewed changes

gumb0 merged commit f500580 into master Oct 15, 2020

gumb0 deleted the capi_func_type branch October 15, 2020 12:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C API function type #557

C API function type #557

gumb0 commented Sep 28, 2020

codecov bot commented Sep 28, 2020 •

edited

Loading

gumb0 Sep 30, 2020

gumb0 Oct 13, 2020

gumb0 commented Oct 13, 2020

chfast commented Oct 13, 2020

axic commented Oct 14, 2020

gumb0 commented Oct 14, 2020

chfast Oct 14, 2020

gumb0 Oct 14, 2020

chfast Oct 14, 2020

gumb0 Oct 14, 2020 •

edited

Loading

axic Oct 14, 2020

gumb0 Oct 14, 2020

axic Oct 14, 2020

gumb0 Oct 14, 2020

axic commented Oct 14, 2020

gumb0 commented Oct 14, 2020

axic Oct 14, 2020

axic left a comment

	/// Output type, can be FizzyValueTypeVoid, if function has no output.
	/// Output type, equals to FizzyValueTypeVoid, if function has no output.

	/// defined in module. Behaviour is undefined, index is not valid according to
	/// defined in module. Behaviour is undefined if index is not valid according to

C API function type #557

C API function type #557

Conversation

gumb0 commented Sep 28, 2020

codecov bot commented Sep 28, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gumb0 commented Oct 13, 2020

chfast commented Oct 13, 2020

axic commented Oct 14, 2020

gumb0 commented Oct 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gumb0 Oct 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

axic commented Oct 14, 2020

gumb0 commented Oct 14, 2020

Choose a reason for hiding this comment

axic left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 28, 2020 •

edited

Loading

gumb0 Oct 14, 2020 •

edited

Loading