Add value type to ExternalGlobal and check it at instantiate #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
external-global-type
branch
2 times, most recently
from
9f53c73 to
3260379
Compare
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 99.56% 99.68% +0.11%
==========================================
Files 54 54
Lines 17163 17202 +39
==========================================
+ Hits 17089 17147 +58
+ Misses 74 55 -19 |
gumb0
changed the title
gumb0
force-pushed
the
external-global-type
branch
2 times, most recently
from
88669a0 to
2e82cf4
Compare
chfast
approved these changes
Aug 18, 2020
| EXPECT_THROW_MESSAGE( | ||
| instantiate(module2, {}, {}, {}, {*g}), instantiate_error, "type mismatch"); | ||
| EXPECT_THROW_MESSAGE(instantiate(module2, {}, {}, {}, {*g}), instantiate_error, | ||
| "global 0 value type doesn't match module's global type"); |
There was a problem hiding this comment.
Modify or and a test where non-0 global is wrong.
There was a problem hiding this comment.
Added a case to imported_globals_mismatched_type test
gumb0
force-pushed
the
external-global-type
branch
from
2e82cf4 to
f62d860
Compare
chfast
approved these changes
Aug 19, 2020
axic
approved these changes
Aug 19, 2020
axic
force-pushed
the
external-global-type
branch
from
f62d860 to
31ae7c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the disabled instantiation test.
Not covered by spec tests.