Implement f{32,64}.div instructions #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chfast
commented
Aug 10, 2020
•
chfast
commented
chfast
force-pushed
the
fp_add
branch
3 times, most recently
from
0ee2182 to
c6547b9
Compare
chfast
force-pushed
the
fp_div
branch
2 times, most recently
from
4abda86 to
74a1c1c
Compare
chfast
force-pushed
the
fp_add
branch
7 times, most recently
from
403e427 to
e8c2b15
Compare
chfast
force-pushed
the
fp_div
branch
2 times, most recently
from
6435f60 to
717a89a
Compare
|
Some UBSan errors on macOS |
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 54 54
Lines 16123 16196 +73
=======================================
+ Hits 16049 16122 +73
Misses 74 74 |
chfast
commented
Aug 12, 2020
| @@ -510,6 +510,13 @@ inline uint64_t popcnt64(uint64_t value) noexcept | |||
| return static_cast<uint64_t>(__builtin_popcountll(value)); | |||
| } | |||
|
|
|||
| template <typename T> | |||
| __attribute__((no_sanitize("float-divide-by-zero"))) inline constexpr T fdiv(T a, T b) noexcept | |||
There was a problem hiding this comment.
The attribute disables UBSan check in both GCC and Clang. Using C++ attributes ([[gnu::no_sanitize("")]]) is also possible but requires some changes to compiler's warning options. So I think it is fine to leave it as is for now.
chfast
changed the title
gumb0
approved these changes
Aug 12, 2020
|
@axic, I added spec annotations in tests. |
axic
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.