Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Remove explicit uint64_t cast from Value #464

Merged
merged 5 commits into from
Aug 24, 2020
Merged

tests: Remove explicit uint64_t cast from Value #464

merged 5 commits into from
Aug 24, 2020

Conversation

axic
Copy link
Member

@axic axic commented Aug 7, 2020

No description provided.

Base automatically changed from value-cast to master August 7, 2020 12:44
@axic axic force-pushed the simplify-value branch 2 times, most recently from 101df38 to 67fe9f2 Compare August 7, 2020 18:41
axic
axic commented Aug 7, 2020
View reviewed changes
test/unittests/parser_test.cpp Outdated Show resolved Hide resolved
@axic axic requested a review from gumb0 August 7, 2020 18:47
gumb0
gumb0 reviewed Aug 10, 2020
View reviewed changes
test/unittests/api_test.cpp Outdated Show resolved Hide resolved
@axic axic marked this pull request as ready for review August 10, 2020 12:36
@axic axic requested review from gumb0 and chfast August 10, 2020 12:36
@axic
Copy link
Member Author

axic commented Aug 10, 2020

Should squash the separate commits of test before merging.

@codecov
Copy link

codecov bot commented Aug 10, 2020 •
edited
Loading

Codecov Report

Merging #464 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #464   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          54       54           
  Lines       17175    17183    +8     
=======================================
+ Hits        17123    17131    +8     
  Misses         52       52

@axic axic changed the title Remove explicit uint64_t cast from Value tests: Remove explicit uint64_t cast from Value Aug 11, 2020
@axic
Copy link
Member Author

axic commented Aug 17, 2020

@gumb0 this is still waiting for a thorough review from you, I'd like to merge this.

@axic axic force-pushed the simplify-value branch 4 times, most recently from 582056e to e816455 Compare August 23, 2020 12:42
axic
axic commented Aug 23, 2020
View reviewed changes
test/utils/asserts.hpp Outdated Show resolved Hide resolved
chfast
chfast reviewed Aug 23, 2020
View reviewed changes
test/utils/asserts.hpp Outdated Show resolved Hide resolved
test/utils/asserts.hpp Outdated Show resolved Hide resolved
chfast
chfast reviewed Aug 23, 2020
View reviewed changes
test/utils/asserts.hpp Outdated Show resolved Hide resolved
@axic axic requested a review from chfast August 24, 2020 10:44
chfast
chfast reviewed Aug 24, 2020
View reviewed changes
test/unittests/execute_call_test.cpp Show resolved Hide resolved
test/utils/asserts.hpp Outdated Show resolved Hide resolved
test/unittests/parser_test.cpp Outdated Show resolved Hide resolved
@axic axic force-pushed the simplify-value branch 3 times, most recently from 101e042 to ebc654e Compare August 24, 2020 12:03
@axic axic requested a review from chfast August 24, 2020 12:03
@axic axic mentioned this pull request Aug 24, 2020
Closed
@axic axic merged commit 7cf652c into master Aug 24, 2020
@axic axic deleted the simplify-value branch August 24, 2020 12:30
@chfast chfast mentioned this pull request Aug 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gumb0 gumb0 gumb0 left review comments

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axic @chfast @gumb0