Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute noexcept #438

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Execute noexcept #438

merged 1 commit into from
Aug 23, 2020

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Jul 28, 2020 •
edited
Loading

Eliminate the throw unsupported_feature from execute() and mark it with noexcept.

@chfast chfast force-pushed the execute_noexcept branch from 0cdd51a to 9998eac Compare July 28, 2020 15:04
@chfast
Copy link
Collaborator Author

chfast commented Jul 28, 2020

It has some potential:

fizzy/execute/blake2b/512_bytes_rounds_1_mean                     -0.0199         -0.0199            84            82            84            82
fizzy/execute/blake2b/512_bytes_rounds_16_mean                    -0.0225         -0.0225          1269          1240          1269          1240
fizzy/execute/ecpairing/onepoint_mean                             -0.0541         -0.0541        431244        407923        431248        407925
fizzy/execute/keccak256/512_bytes_rounds_1_mean                   ~
fizzy/execute/keccak256/512_bytes_rounds_16_mean                  -0.0077         -0.0077          1457          1445          1457          1445
fizzy/execute/memset/256_bytes_mean                               -0.0119         -0.0119             7             7             7             7
fizzy/execute/memset/60000_bytes_mean                             -0.0112         -0.0112          1548          1531          1548          1531
fizzy/execute/mul256_opt0/input0_mean                             ~
fizzy/execute/mul256_opt0/input1_mean                             ~
fizzy/execute/sha1/512_bytes_rounds_1_mean                        -0.0057         -0.0057            91            90            91            90
fizzy/execute/sha1/512_bytes_rounds_16_mean                       -0.0017         -0.0017          1257          1255          1257          1255
fizzy/execute/sha256/512_bytes_rounds_1_mean                      -0.0770         -0.0770            97            90            97            90
fizzy/execute/sha256/512_bytes_rounds_16_mean                     -0.0736         -0.0736          1338          1240          1338          1240
fizzy/execute/micro/eli_interpreter/halt_mean                     -0.0262         -0.0262             0             0             0             0
fizzy/execute/micro/eli_interpreter/exec105_mean                  -0.0170         -0.0170             5             5             5             5
fizzy/execute/micro/factorial/10_mean                             -0.0374         -0.0374             0             0             0             0
fizzy/execute/micro/factorial/20_mean                             -0.0188         -0.0188             1             1             1             1
fizzy/execute/micro/fibonacci/24_mean                             -0.0088         -0.0088          7541          7475          7542          7475
fizzy/execute/micro/host_adler32/1_mean                           -0.0065         -0.0065             0             0             0             0
fizzy/execute/micro/host_adler32/100_mean                         -0.0061         -0.0061             3             3             3             3
fizzy/execute/micro/host_adler32/1000_mean                        ~
fizzy/execute/micro/spinner/1_mean                                +0.0232         +0.0232             0             0             0             0
fizzy/execute/micro/spinner/1000_mean                             +0.0047         +0.0047            10            10            10            10

@chfast chfast force-pushed the execute_noexcept branch 2 times, most recently from 212020b to 18c9054 Compare August 21, 2020 19:32
@chfast chfast changed the base branch from master to fp_nearest August 21, 2020 19:32
@chfast chfast requested a review from axic August 21, 2020 19:33
@chfast chfast marked this pull request as ready for review August 21, 2020 19:33
@codecov
Copy link

codecov bot commented Aug 21, 2020 •
edited
Loading

Codecov Report

Merging #438 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          54       54           
  Lines       17180    17180           
=======================================
  Hits        17125    17125           
  Misses         55       55

@chfast chfast force-pushed the fp_nearest branch 2 times, most recently from 86f4c39 to 55e3315 Compare August 21, 2020 21:58
Base automatically changed from fp_nearest to master August 21, 2020 22:15
axic
axic approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the last commit is the only remaining.

@chfast
Copy link
Collaborator Author

chfast commented Aug 23, 2020

Latest measurements:

fizzy/execute/blake2b/512_bytes_rounds_1            -0.0104            78            77
fizzy/execute/blake2b/512_bytes_rounds_16           -0.0111          1174          1161
fizzy/execute/ecpairing/onepoint                    -0.0318        397551        384903
fizzy/execute/keccak256/512_bytes_rounds_1          -0.0246            96            94
fizzy/execute/keccak256/512_bytes_rounds_16               ~          1401          1397
fizzy/execute/memset/256_bytes                      -0.0069             6             6
fizzy/execute/memset/60000_bytes                    -0.0024          1401          1398
fizzy/execute/mul256_opt0/input0                    -0.0219            25            25
fizzy/execute/mul256_opt0/input1                    -0.0193            25            25
fizzy/execute/sha1/512_bytes_rounds_1               -0.0106            85            84
fizzy/execute/sha1/512_bytes_rounds_16              -0.0093          1182          1171
fizzy/execute/sha256/512_bytes_rounds_1             -0.0221            86            84
fizzy/execute/sha256/512_bytes_rounds_16            -0.0220          1186          1160
fizzy/execute/micro/eli_interpreter/halt            +0.2530             0             0
fizzy/execute/micro/eli_interpreter/exec105         +0.0114             4             4
fizzy/execute/micro/factorial/10                    +0.0083             0             0
fizzy/execute/micro/factorial/20                    +0.0040             1             1
fizzy/execute/micro/fibonacci/24                    +0.0164          7111          7228
fizzy/execute/micro/host_adler32/1                  -0.0146             0             0
fizzy/execute/micro/host_adler32/100                      ~             3             3
fizzy/execute/micro/host_adler32/1000               +0.0055            29            29
fizzy/execute/micro/spinner/1                       +0.0221             0             0
fizzy/execute/micro/spinner/1000                    -0.0021             9             9

@chfast chfast merged commit 2323ad8 into master Aug 23, 2020
@chfast chfast deleted the execute_noexcept branch August 23, 2020 09:43
@axic axic mentioned this pull request Aug 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @axic