Validate functions' arity #433
Conversation
test/unittests/validation_test.cpp
Outdated
| @@ -13,6 +13,15 @@ | |||
| using namespace fizzy; | |||
| using namespace fizzy::test; | |||
|
|
|||
| TEST(validation, imported_function_type_invalid_arity) | |||
| { | |||
| /* wat2wasm | |||
There was a problem hiding this comment.
wabt doesn't throw an error unless function with this type is defined
There was a problem hiding this comment.
Can you add this to our list of "to reach out"? Or just ask the question on the wabt repo? It may be we are using an old wabt and it was fixed since, or perhaps they are more committed to the multi-return-value change (I believe that is implemented by wabt).
There was a problem hiding this comment.
I tried it with recent wabt 1.0.19, and it appears to be fixed: multi-value is enabled by default there, but with --disable-multi-value this correctly throws an error.
I think I'll add --no-check here
There was a problem hiding this comment.
1.0.14 is the last one that has multi-value disabled by default, and it has this issue fixed also.
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 50 50
Lines 13978 13989 +11
=======================================
+ Hits 13883 13894 +11
Misses 95 95 |
test/unittests/validation_test.cpp
Outdated
| @@ -13,6 +13,15 @@ | |||
| using namespace fizzy; | |||
| using namespace fizzy::test; | |||
|
|
|||
| TEST(validation, imported_function_type_invalid_arity) | |||
There was a problem hiding this comment.
This is not imported, just function_type_invalid_arity
gumb0
force-pushed
the
validate-func-arity
branch
from
cee3935
to
8896019
Compare
gumb0
force-pushed
the
validate-func-arity
branch
from
8896019
to
10fa4d5
Compare
No description provided.