Validate missing else branch #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
==========================================
+ Coverage 99.32% 99.33% +0.01%
==========================================
Files 50 50
Lines 14075 14169 +94
==========================================
+ Hits 13980 14075 +95
+ Misses 95 94 -1 |
gumb0
force-pushed
the
validate-missing-else
branch
from
9ef06c0 to
0ef2d6d
Compare
gumb0
force-pushed
the
validate-types-block
branch
2 times, most recently
from
e8db0dc to
98ae70c
Compare
|
@gumb0 rebase plase |
gumb0
force-pushed
the
validate-missing-else
branch
from
0ef2d6d to
018b7bf
Compare
gumb0
commented
Jul 20, 2020
| @@ -468,10 +467,15 @@ parser_result<Code> parse_expr(const uint8_t* pos, const uint8_t* end, FuncIdx f | |||
|
|
|||
| update_result_stack(frame, operand_stack); // else is the end of if. | |||
|
|
|||
| // Reset frame after if. | |||
| frame.unreachable = false; | |||
There was a problem hiding this comment.
I decided here at else instruction to pop the frame and push a new one instead of overwriting fields in the top one.
This way we can keep both instruction and immediates_offset fields const in ControlFrame, and it just seems more logical to push a new one, because it's different frame.
But this requires to transfer the contents of br_immediate_offsets from the old top frame to the new one.
gumb0
force-pushed
the
validate-missing-else
branch
from
018b7bf to
b65b462
Compare
chfast
approved these changes
Jul 23, 2020
chfast
approved these changes
Jul 23, 2020
gumb0
force-pushed
the
validate-missing-else
branch
from
b65b462 to
15eb164
Compare
axic
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #407