Remove instruction metrics (except max align) #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 99.33% 99.36% +0.02%
==========================================
Files 50 49 -1
Lines 14175 14169 -6
==========================================
- Hits 14081 14079 -2
+ Misses 94 90 -4 |
gumb0
force-pushed
the
remove-instr-metrics
branch
from
36347e2 to
82ef0cb
Compare
axic
force-pushed
the
validate-types-no-block-br
branch
3 times, most recently
from
7d2c6c3 to
3adfb02
Compare
gumb0
force-pushed
the
validate-types-no-block-br
branch
2 times, most recently
from
0d30b02 to
7beb186
Compare
gumb0
force-pushed
the
remove-instr-metrics
branch
from
82ef0cb to
13f124c
Compare
axic
reviewed
Jul 17, 2020
| @@ -248,7 +248,6 @@ parser_result<Code> parse_expr(const uint8_t* pos, const uint8_t* end, FuncIdx f | |||
| std::tie(opcode, pos) = parse_byte(pos, end); | |||
|
|
|||
| auto& frame = control_stack.top(); | |||
| const auto& metrics = metrics_table[opcode]; | |||
| const auto& type = type_table[opcode]; | |||
There was a problem hiding this comment.
Why? It's used only in subset of instructions, which are handled all in one switch case, so why put it into wider scope?
There was a problem hiding this comment.
My reasoning is that none of the cases in the switch use the opcode variable and one must go up to the top to find it. Perhaps benchmarking can show which is faster :)
There was a problem hiding this comment.
Tried to benchmark, it doesn't make any difference.
There was a problem hiding this comment.
If there's no speed difference I'd prefer it at the top.
There was a problem hiding this comment.
Made max_align variable.
gumb0
force-pushed
the
remove-instr-metrics
branch
from
13f124c to
87bea74
Compare
axic
approved these changes
Jul 17, 2020
axic
force-pushed
the
remove-instr-metrics
branch
3 times, most recently
from
9b97f70 to
a019c4a
Compare
chfast
approved these changes
Jul 28, 2020
gumb0
force-pushed
the
remove-instr-metrics
branch
from
a019c4a to
1b71bc7
Compare
gumb0
force-pushed
the
remove-instr-metrics
branch
from
1b71bc7 to
cd1903d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #403