refactor: Unify stack height handling for instructions and calls in parser #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
- Coverage 99.32% 99.32% -0.01%
==========================================
Files 42 42
Lines 12829 12808 -21
==========================================
- Hits 12743 12722 -21
Misses 86 86 |
gumb0
force-pushed
the
simplify-stack-checks
branch
from
948e54d to
0565bef
Compare
chfast
approved these changes
Jun 17, 2020
axic
approved these changes
Jun 24, 2020
validate_result_count and validate_branch_stack_height have similar checks.
gumb0
force-pushed
the
simplify-stack-checks
branch
from
0565bef to
65d954b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change suggested in #384 (comment)