Fix reading parent stack height from branch instructions immediates #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
imm-stack-height-read
branch
from
3fe601e to
33219f6
Compare
axic
approved these changes
Jun 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 42 42
Lines 12184 12184
=======================================
Hits 12044 12044
Misses 140 140 |
chfast
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pushed to immediates as
uint32_t, and should be read with the same type.fizzy/lib/fizzy/parser_expr.cpp
Line 128 in 5db0431