Enable "too many results" stack height validation #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
reviewed
May 28, 2020
| @@ -160,7 +180,7 @@ TEST(validation_stack, loop_with_result_stack_underflow) | |||
| EXPECT_THROW_MESSAGE(parse(wasm), validation_error, "stack underflow"); | |||
| } | |||
|
|
|||
| TEST(validation_stack, DISABLED_loop_too_many_results) | |||
| TEST(validation_stack, loop_too_many_results) | |||
There was a problem hiding this comment.
Another test suggestion, not sure if already exists: unreachable insrtuction after br that would push extra result, but should be valid, as it's unreachable.
There was a problem hiding this comment.
This is actually invalid. You cannot have additional items in polymorphic stack.
chfast
force-pushed
the
stack_height_validation
branch
from
2da5e2c to
71ef8ae
Compare
chfast
force-pushed
the
stack_height_validation
branch
from
71ef8ae to
5953401
Compare
chfast
force-pushed
the
stack_height_validation
branch
from
89039ef to
80b015e
Compare
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
==========================================
+ Coverage 98.94% 99.11% +0.17%
==========================================
Files 42 42
Lines 12317 12357 +40
==========================================
+ Hits 12187 12248 +61
+ Misses 130 109 -21 |
gumb0
reviewed
Jun 8, 2020
| @@ -252,8 +252,8 @@ jobs: | |||
| - benchmark: | |||
| min_time: "0.01" | |||
| - spectest: | |||
| expected_passed: 4903 | |||
| expected_failed: 529 | |||
| expected_passed: 4997 | |||
There was a problem hiding this comment.
wow nice increase
My PRs are getting like 2 new tests passed 😖
There was a problem hiding this comment.
This is part of type validation, so I expect it has a lot of test cases.
gumb0
reviewed
Jun 8, 2020
| @@ -482,6 +502,33 @@ TEST(validation_stack, unreachable_call_indirect) | |||
| parse(wasm); | |||
| } | |||
|
|
|||
| TEST(validation_stack, unreachable_too_many_results) | |||
| { | |||
| // TODO: These are actually examples of invalid wasm. | |||
There was a problem hiding this comment.
Then maybe better to make it disabled tests expecting exception?
gumb0
approved these changes
Jun 8, 2020
chfast
force-pushed
the
stack_height_validation
branch
from
80b015e to
553a7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #355.