Change exception messages to lowercase + no-dot #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
reviewed
May 21, 2020
| @@ -175,7 +175,7 @@ inline parser_result<Global> parse(const uint8_t* pos, const uint8_t* end) | |||
| inline parser_result<Limits> parse_limits(const uint8_t* pos, const uint8_t* end) | |||
| { | |||
| if (pos == end) | |||
| throw parser_error{"Unexpected EOF"}; | |||
| throw parser_error{"unexpected EOF"}; | |||
There was a problem hiding this comment.
I would do something more about this one. It is repeated many times and the error message is confusing as it can mean the unexpected end of a section.
There was a problem hiding this comment.
I'd reword them in a different PR, if it needs to be done.
gumb0
approved these changes
May 22, 2020
chfast
approved these changes
May 22, 2020
axic
force-pushed
the
exception-style
branch
3 times, most recently
from
f7833d3 to
b3778b3
Compare
gumb0
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.