refactor: Unify br and return execution implementation #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
- Coverage 99.12% 99.12% -0.01%
==========================================
Files 36 36
Lines 10173 10168 -5
==========================================
- Hits 10084 10079 -5
Misses 89 89 |
gumb0
force-pushed
the
return-is-the-new-br
branch
3 times, most recently
from
106a70a to
474303e
Compare
gumb0
commented
May 7, 2020
chfast
reviewed
May 7, 2020
gumb0
force-pushed
the
return-is-the-new-br
branch
from
474303e to
61cab4b
Compare
chfast
approved these changes
May 7, 2020
|
Rebase wasn't enough as #281 changed interfaces. I also suggest we move this to 0.2.0 as it could affect speed. |
gumb0
force-pushed
the
return-is-the-new-br
branch
from
1e31190 to
a9f9f5a
Compare
|
@gumb0 can you rebase and post benchmarking difference between master and this change? |
gumb0
force-pushed
the
return-is-the-new-br
branch
from
a9f9f5a to
4dfc807
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.