Indexing into a vector past its end is UB.

wasmx · Apr 24, 2022 · e98428c · e98428c
1 parent 9d9ed3b
commit e98428c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/fizzy/execute.cpp b/lib/fizzy/execute.cpp
@@ -593,7 +593,7 @@ ExecutionResult execute(
         case Instr::end:
         {
             // End execution if it's a final end instruction.
-            if (pc == &code.instructions[code.instructions.size()])
+            if (pc == code.instructions.data() + code.instructions.size())
                 goto end;
             break;
         }
@@ -1563,7 +1563,8 @@ ExecutionResult execute(
     }
 
 end:
-    assert(pc == &code.instructions[code.instructions.size()]);  // End of code must be reached.
+    assert(pc == code.instructions.data() + code.instructions.size());  // End of code must be
+                                                                        // reached.
     assert(stack.size() == instance.module->get_function_type(func_idx).outputs.size());
 
     return stack.size() != 0 ? ExecutionResult{stack.top()} : Void;