Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
gumb0 authored and axic committed Oct 1, 2020
1 parent 9511b99 commit b895580
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions tools/wasi/wasi.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ fizzy::ExecutionResult wasi_fd_write(

std::vector<uvwasi_ciovec_t> iovs(iov_cnt);
// TODO: not sure what to pass as end, passing memory size...
uvwasi_errno_t ret = uvwasi_serdes_readv_ciovec_t(instance.memory->data(),
instance.memory->size(), iov_ptr, iovs.data(), static_cast<uvwasi_size_t>(iovs.size()));
uvwasi_errno_t ret = uvwasi_serdes_readv_ciovec_t(
instance.memory->data(), instance.memory->size(), iov_ptr, iovs.data(), iov_cnt);
if (ret != UVWASI_ESUCCESS)
return fizzy::Value{uint32_t{ret}};

Expand All @@ -62,14 +62,13 @@ fizzy::ExecutionResult wasi_fd_read(

std::vector<uvwasi_iovec_t> iovs(iov_cnt);
// TODO: not sure what to pass as end, passing memory size...
uvwasi_errno_t ret = uvwasi_serdes_readv_iovec_t(instance.memory->data(),
instance.memory->size(), iov_ptr, iovs.data(), static_cast<uvwasi_size_t>(iovs.size()));
uvwasi_errno_t ret = uvwasi_serdes_readv_iovec_t(
instance.memory->data(), instance.memory->size(), iov_ptr, iovs.data(), iov_cnt);
if (ret != UVWASI_ESUCCESS)
return fizzy::Value{uint32_t{ret}};

uvwasi_size_t nread;
ret = uvwasi_fd_read(&state, static_cast<uvwasi_fd_t>(fd), iovs.data(),
static_cast<uvwasi_size_t>(iovs.size()), &nread);
ret = uvwasi_fd_read(&state, static_cast<uvwasi_fd_t>(fd), iovs.data(), iov_cnt, &nread);
uvwasi_serdes_write_uint32_t(instance.memory->data(), nread_ptr, nread);

return fizzy::Value{uint32_t{ret}};
Expand Down

0 comments on commit b895580

Please sign in to comment.