Skip to content

Conversation

@Robbepop
Copy link
Member

So far encountering an internal error simply caused an immediate panic. However, for #1655 and its tail-calls based dispatch we require more control over panics in the interpreter loop which this new API solves.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 73.17073% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.71%. Comparing base (2b3a14c) to head (79eec01).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/store/error.rs 22.22% 21 Missing ⚠️
crates/wasmi/src/store/inner.rs 92.75% 5 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/call.rs 60.00% 2 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/memory.rs 50.00% 2 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/table.rs 50.00% 2 Missing ⚠️
crates/wasmi/src/store/mod.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1679      +/-   ##
==========================================
- Coverage   70.76%   70.71%   -0.05%     
==========================================
  Files         179      180       +1     
  Lines       15199    15228      +29     
==========================================
+ Hits        10755    10768      +13     
- Misses       4444     4460      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop merged commit c3627c1 into main Oct 27, 2025
19 checks passed
@Robbepop Robbepop deleted the rf-redesign-store-internal-errors branch October 27, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants