Skip to content

Conversation

@Robbepop
Copy link
Member

@Robbepop Robbepop commented Mar 26, 2025

  • Fixed a bug in i8x16.shuffle translation where it missed a trivial check for reachability.
  • Fixed an encoding bug for v128.storeN_lane instructions with offsets that could not be 8-bit encoded.
  • Fixed a bug in v128.shift instruction translation with immediate rhs shift amounts.

This missed a trivial check if the current code path is reachable.
@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.21%. Comparing base (2de7c09) to head (abe8cdb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/translator/simd/mod.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1429   +/-   ##
=======================================
  Coverage   71.21%   71.21%           
=======================================
  Files         161      161           
  Lines       16269    16270    +1     
=======================================
+ Hits        11586    11587    +1     
  Misses       4683     4683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This only affected instructions with offsets that could not be 8-bit encoded.
The error was that in case of an immediate `rhs` shift amount the translation pushed a result and `lhs` back to the stack instead of just `lhs`.
@Robbepop Robbepop changed the title Fix SIMD bugs found by fuzzing Fix some SIMD bugs found by fuzzing Mar 26, 2025
@Robbepop Robbepop merged commit 7949063 into main Mar 27, 2025
19 checks passed
@Robbepop Robbepop deleted the rf-fix-simd-bugs branch March 27, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant