Merge with upstream #234
Merged
Merge with upstream #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_gc_ref` (bytecodealliance#9359) Don't just assert that the given GC refs aren't `i31ref`s, but also that they are of the correct type. Note that the other `from_cloned_gc_ref` methods (on, for example, `AnyRef`) already do their equivalents of these checks. Just these two were a little looser than they should have been.
…ecodealliance#9360) * Disable tail-call when fuzzing the spec interpreter Our copy of the reference interpreter does not implement the tail-call proposal, so fix OSS-Fuzz by disabling it. This technically should have been done in bytecodealliance#9336 when wasm-tools was updated to auto-try to enable this proposal by default, but alas I am not a human fuzzer so I waited until OSS-Fuzz found it. * Also disable relaxed-simd
…nce#9362) This commit fixes an issue found on OSS-Fuzz for the cranelift-fuzzgen fuzzer which was caused by bytecodealliance#9338 but that PR forgot to fix.
…e#9371) * Update pulley-interpreter and winch-codegen versions Update these two crates to match the Wasmtime crate version instead of having separate version tracks. Helps keep everything in-sync with fewer versions to worry about in general. * Update cargo-vet
This PR is intended to help unblock bytecodealliance#9178. That PR uncovered the consequence that testing the `cranelift-reader` crate alone does not work on non-x86_64 platforms. One of its tests relies on parsing the `x86_64` target specification to work, and that only works if the `x86` feature of the cranelift-codegen crate is enabled. This PR unconditionally enables this feature when testing. This was uncovered on bytecodealliance#9178 because the set of crates tested in each shard of our sharded builders depends on the set of crates in the workspace. When a new crate is added it may shuffle around which crates are tested in which location. Previously `cranelift-reader` must have been always tested with a crate that unconditionally enables `cranelift-codegen/x86` as a feature, but bytecodealliance#9178 got unlucky where it moved to a set that didn't include this, thus exposing the failure.
* Squash of verification changes 2024-08-28 * Cleanup * fmt * More cleanup * clippy * update example spec * fmt * null * clippy part 1 * clippy fix, null * clippy part 3 * fmt * disable veri_engine tests in CI * clap dependency * remove strum * use easy-smt version * Get `cargo vet/deny` working and passing Undoes a seeming `cargo update` that was performed previously and then adds a vet for the new crate added. * Flag new crates as not published * Revert "remove strum" This reverts commit df7b540. * itertools * Review feedback * Future work comments for encodings * fmt * post merge Cargo.lock updates * authors --------- Co-authored-by: Alex Crichton <[email protected]>
There were a few missing pieces for the readme example to compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.