Remove fibre::{Fiber, Suspend} types #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs a refactoring required by a follow-up PR that will implement actual pooling of
VMContRef
s.This PR removes the types
Fiber
andSuspend
from thefibre
create (i.e., our version ofwasmtime-fiber
). These two types are effectively leftovers fromwasmtime-fiber
, but only add a layer of unnecessary indirection at this point.Note that the
fibre::FiberStack
type remains. Some functions originally implemented onFiber
are moved toFiberStack
now. Further, theVMContRef
definition used in the optimized implementation now owns afibre::FiberStack
directly, rather than storing aFiber
as a wrapper around theFiberStack
.This PR does not affect the baseline implementation since it doesn't use the
fibre
crate at all.