-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable compilation for specific target #964
Conversation
Thanks for the PR. It looks interesting. Maybe @nlewycky can provide me valuable insights. |
bors r+ |
964: Enable compilation for specific target r=syrusakbary a=xofyarg <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> By exposing the target information through `CompilerConfig`, compiler(only LLVM at the moment) could create a machine with different CPU feature flags other than current host, which makes it capable to "cross compile" to some degree. Update #959 # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: anb <[email protected]>
Build failed
|
@xofyarg it seems From tests:
Once that's addressed it should be good to merge! |
PR updated. |
@xofyarg Can you add a brief explanation to the I'll ship it as soon that's updated! |
By exposing the target information through `CompilerConfig`, compiler(only LLVM at the moment) could create a machine with different CPU feature flags other than current host, which makes it capable to "cross compile" to some degree. Update wasmerio#959
Brief explanation added and rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect -- thank you!
bors r+ |
964: Enable compilation for specific target r=MarkMcCaskey a=xofyarg <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> By exposing the target information through `CompilerConfig`, compiler(only LLVM at the moment) could create a machine with different CPU feature flags other than current host, which makes it capable to "cross compile" to some degree. Update #959 # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: anb <[email protected]>
Build succeeded
|
Description
By exposing the target information through
CompilerConfig
,compiler(only LLVM at the moment) could create a machine with
different CPU feature flags other than current host, which makes it
capable to "cross compile" to some degree.
Update #959
Review