Deny missing docs in runtime core and add missing docs #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewycky
approved these changes
Nov 10, 2019
| #[repr(u8)] | ||
| #[derive(Copy, Clone, Debug, Eq, PartialEq, Ord, PartialOrd, Hash)] | ||
| pub enum GPR { | ||
| /// RAX Register |
There was a problem hiding this comment.
Is there a way to suppress the extra comments here? These aren't adding value, and they're doubling the number of lines.
There was a problem hiding this comment.
@nlewycky They can be suppressed individually using #[doc(hidden)] but that would be the same number of lines. I think they would all be suppressed with #[doc(hidden)] on the enum but then we wouldn't get a doc for that.
|
bors try |
|
bors try |
tryAlready running a review |
tryBuild failed
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 10, 2019
942: Deny missing docs in runtime core and add missing docs r=bjfish a=bjfish <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Deny missing docs in runtime core and add missing docs <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Brandon Fish <[email protected]>
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 10, 2019
942: Deny missing docs in runtime core and add missing docs r=bjfish a=bjfish <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Deny missing docs in runtime core and add missing docs <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Brandon Fish <[email protected]>
Build succeeded
|
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deny missing docs in runtime core and add missing docs
Review