Fix WASI append bug, add test #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCaskey
force-pushed
the
fix/wasi-append
branch
from
3b699df to
6478342
Compare
|
Thank you for the tests 🙏 |
syrusakbary
approved these changes
Nov 8, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 8, 2019
939: Fix WASI append bug, add test r=MarkMcCaskey a=MarkMcCaskey resolves #936 Co-authored-by: Mark McCaskey <[email protected]>
nlewycky
reviewed
Nov 8, 2019
| @@ -83,7 +83,7 @@ pub fn compile(file: &str, ignores: &HashSet<String>) -> Option<String> { | |||
| .arg("+nightly") | |||
| .arg("--target=wasm32-wasi") | |||
| .arg("-C") | |||
| .arg("opt-level=s") | |||
| .arg("opt-level=z") | |||
There was a problem hiding this comment.
This seems like it's part of a different change?
There was a problem hiding this comment.
It is, but using a new version of nightly locally means all the generated wasm modules will change anyways, so I figured I might as well make this change that I've been meaning to make for a while anyways
Build failed
|
|
bors retry |
|
bors r- |
Canceled |
|
bors r+ |
Merge conflict (retrying...) |
Merge conflict |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 8, 2019
939: Fix WASI append bug, add test r=syrusakbary a=MarkMcCaskey resolves #936 Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
|
bors r- |
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 8, 2019
938: Fuzz all the backends. r=nlewycky a=nlewycky  939: Fix WASI append bug, add test r=MarkMcCaskey a=MarkMcCaskey resolves #936 Co-authored-by: Nick Lewycky <[email protected]> Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Build failed (retrying...)
|
bors bot
added a commit
that referenced
this pull request
Nov 9, 2019
939: Fix WASI append bug, add test r=MarkMcCaskey a=MarkMcCaskey resolves #936 Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 9, 2019
939: Fix WASI append bug, add test r=MarkMcCaskey a=MarkMcCaskey resolves #936 Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #936