Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(win-exception-handler) Remove bindgen and regex from cargo build deps #886

Merged
merged 1 commit into from
Oct 22, 2019
Merged

fix(win-exception-handler) Remove bindgen and regex from cargo build deps #886

merged 1 commit into from
Oct 22, 2019

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Oct 17, 2019

Those crates are not used.

@Hywan Hywan added bug Something isn't working 📦 lib-win-exception-handler labels Oct 17, 2019
@Hywan Hywan requested review from bjfish and losfair as code owners October 17, 2019 21:55
@Hywan Hywan self-assigned this Oct 17, 2019
@Hywan
Copy link
Contributor Author

Hywan commented Oct 17, 2019

bors try

bors bot added a commit that referenced this pull request Oct 17, 2019
@bors
Try #886:
6e2e4b5
@Hywan Hywan mentioned this pull request Oct 17, 2019
Closed
5 tasks
@bors
Copy link
Contributor

bors bot commented Oct 17, 2019

try

Build succeeded

  • wasmerio.wasmer

@syrusakbary syrusakbary merged commit fe158d0 into wasmerio:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@bjfish bjfish Awaiting requested review from bjfish

@losfair losfair Awaiting requested review from losfair

Assignees

@Hywan Hywan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hywan @syrusakbary