fix(cranelift-backend) Remove broken (and useless?) debug code #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This debug code is broken (it doesn't compile). It can be assumed nobody uses it, and can be considered as dead code. As such, this PR removes it.
Hywan
added
bug
|
bors try |
5 tasks
nlewycky
approved these changes
Oct 17, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
885: fix(cranelift-backend) Remove broken (and useless?) debug code r=nlewycky a=Hywan This debug code is broken (it doesn't compile). It can be assumed nobody uses it, and can be considered as dead code. As such, this PR removes it. The `debug` feature is kept in `Cargo.toml` to activate `wasmer-runtime-core/debug`. Co-authored-by: Ivan Enderlin <[email protected]>
tryBuild succeeded
|
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This debug code is broken (it doesn't compile). It can be assumed
nobody uses it, and can be considered as dead code. As such, this PR
removes it.
The
debugfeature is kept inCargo.tomlto activatewasmer-runtime-core/debug.