Initial implementation of assert_uninstantiable.
#867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCaskey
approved these changes
Oct 7, 2019
|
Actually, if it's sufficiently obvious given the rest of this file, then don't worry about it |
|
Assert that the module described is not instantiable, where instantiate is the process defined in the webassembly spec, for wasmer it means producing a |
|
bors r+ |
Merge conflict |
nlewycky
force-pushed
the
feature/assert-trap-linking
branch
from
d33f290 to
4dc3d81
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 8, 2019
867: Initial implementation of `assert_uninstantiable`. r=nlewycky a=nlewycky # Description Add a basic implementation of `assert_uninstantiable` in the spectest runner. Fixes one line of spectests in all three backends. Co-authored-by: Nick Lewycky <[email protected]>
Build failed
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 9, 2019
867: Initial implementation of `assert_uninstantiable`. r=syrusakbary a=nlewycky # Description Add a basic implementation of `assert_uninstantiable` in the spectest runner. Fixes one line of spectests in all three backends. Co-authored-by: Nick Lewycky <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 9, 2019
867: Initial implementation of `assert_uninstantiable`. r=syrusakbary a=nlewycky # Description Add a basic implementation of `assert_uninstantiable` in the spectest runner. Fixes one line of spectests in all three backends. Co-authored-by: Nick Lewycky <[email protected]> Co-authored-by: Syrus Akbary <[email protected]> Co-authored-by: Syrus <[email protected]>
Canceled |
|
bors r+ |
Canceled |
|
bors r+ |
|
Thanks @syrusakbary ! |
bors bot
added a commit
that referenced
this pull request
Oct 9, 2019
867: Initial implementation of `assert_uninstantiable`. r=nlewycky a=nlewycky # Description Add a basic implementation of `assert_uninstantiable` in the spectest runner. Fixes one line of spectests in all three backends. Co-authored-by: Nick Lewycky <[email protected]> Co-authored-by: Syrus Akbary <[email protected]> Co-authored-by: Syrus <[email protected]> Co-authored-by: nlewycky <[email protected]>
Build failed
|
bjfish
approved these changes
Oct 10, 2019
nlewycky
force-pushed
the
feature/assert-trap-linking
branch
from
f12563e to
a79fcb7
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 15, 2019
867: Initial implementation of `assert_uninstantiable`. r=nlewycky a=nlewycky # Description Add a basic implementation of `assert_uninstantiable` in the spectest runner. Fixes one line of spectests in all three backends. Co-authored-by: Nick Lewycky <[email protected]> Co-authored-by: Syrus <[email protected]> Co-authored-by: nlewycky <[email protected]>
Build failed
|
nlewycky
added a commit
that referenced
this pull request
Oct 17, 2019
Duplicate of PR #867 for Windows testing.
…runner. This exclusion is no worse than before where this test was silently ignored.
nlewycky
force-pushed
the
feature/assert-trap-linking
branch
from
335520a to
6753999
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 18, 2019
867: Initial implementation of `assert_uninstantiable`. r=nlewycky a=nlewycky # Description Add a basic implementation of `assert_uninstantiable` in the spectest runner. Fixes one line of spectests in all three backends. Co-authored-by: Nick Lewycky <[email protected]>
Build failed
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 18, 2019
867: Initial implementation of `assert_uninstantiable`. r=nlewycky a=nlewycky # Description Add a basic implementation of `assert_uninstantiable` in the spectest runner. Fixes one line of spectests in all three backends. Co-authored-by: Nick Lewycky <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a basic implementation of
assert_uninstantiablein the spectest runner. Fixes one line of spectests in all three backends.