adding tests for state_creator of import_object
#865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaronWittenstein
force-pushed
the
import-object-state-creator-tests
branch
from
20acb96 to
170ffa2
Compare
MarkMcCaskey
reviewed
Oct 7, 2019
lib/runtime-core/src/lib.rs
Outdated
| @@ -1,4 +1,4 @@ | |||
| #![deny( | |||
| #![allow( | |||
There was a problem hiding this comment.
This should be changed back!
There was a problem hiding this comment.
@MarkMcCaskey my bad
lib/runtime-core/src/import.rs
Outdated
|
|
||
| #[test] | ||
| fn state_creator_closure() { | ||
| let ptr = std::ptr::null(); |
There was a problem hiding this comment.
Perhaps we should use a sentinel value, 0 is a common bit pattern in memory, something like:
let ptr = unsafe { std::mem::transmute(0xB7B7A0A01234) };
would make the test more robust I think
YaronWittenstein
force-pushed
the
import-object-state-creator-tests
branch
from
343463c to
4adfbc4
Compare
MarkMcCaskey
approved these changes
Oct 7, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 25, 2019
865: adding tests for `state_creator` of `import_object` r=MarkMcCaskey a=YaronWittenstein Part of the PR #807 changes was adding support for shared import objects between threads. https://github.com/wasmerio/wasmer/pull/807/files#diff-d20cb4c5a883566b85be4cc046f45aa9R49 I've added tests/examples on how to create an `import object` with a state_creator (function or closure) Co-authored-by: Yaron Wittenstein <[email protected]>
Build failed |
@MarkMcCaskey can you please re-trigger |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 2, 2019
865: adding tests for `state_creator` of `import_object` r=MarkMcCaskey a=YaronWittenstein Part of the PR #807 changes was adding support for shared import objects between threads. https://github.com/wasmerio/wasmer/pull/807/files#diff-d20cb4c5a883566b85be4cc046f45aa9R49 I've added tests/examples on how to create an `import object` with a state_creator (function or closure) Co-authored-by: Yaron Wittenstein <[email protected]>
|
Thanks! Sorry about not shipping this before -- I only very recently learned/realized that not everyone can use bors on Wasmer! I assumed given an approval, people could ship their own PRs, but this seems to not be the case! There are a few other PRs I didn't ship due to this misunderstanding which I'll be following up on |
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 6, 2019
709: new feature flag: `deterministic` r=MarkMcCaskey a=YaronWittenstein The motivation for the PR is for introducing a new feature flag called `deterministic`. When `deterministic` will be enabled (turned-off by default) it'll guarantee deterministic execution of wasm programs across different hardware/circumstances. This is critical for Blockchain projects that require execution to be deterministic in order to reach a consensus of the state transition of each smart-contract transaction. 865: adding tests for `state_creator` of `import_object` r=MarkMcCaskey a=YaronWittenstein Part of the PR #807 changes was adding support for shared import objects between threads. https://github.com/wasmerio/wasmer/pull/807/files#diff-d20cb4c5a883566b85be4cc046f45aa9R49 I've added tests/examples on how to create an `import object` with a state_creator (function or closure) 1042: Make regression test work in release builds too. r=nlewycky a=nlewycky Fix this regression test to detect the bug it was looking for in release builds too. This bug triggered an assertion failure in debug, and by examining the pre-opt IR, we can check for the bug in release mode too. Co-authored-by: Yaron Wittenstein <[email protected]> Co-authored-by: Yaron Wittenstein <[email protected]> Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Nick Lewycky <[email protected]>
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Dec 6, 2019
865: adding tests for `state_creator` of `import_object` r=MarkMcCaskey a=YaronWittenstein Part of the PR #807 changes was adding support for shared import objects between threads. https://github.com/wasmerio/wasmer/pull/807/files#diff-d20cb4c5a883566b85be4cc046f45aa9R49 I've added tests/examples on how to create an `import object` with a state_creator (function or closure) 1042: Make regression test work in release builds too. r=nlewycky a=nlewycky Fix this regression test to detect the bug it was looking for in release builds too. This bug triggered an assertion failure in debug, and by examining the pre-opt IR, we can check for the bug in release mode too. Co-authored-by: Yaron Wittenstein <[email protected]> Co-authored-by: Nick Lewycky <[email protected]>
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Dec 6, 2019
865: adding tests for `state_creator` of `import_object` r=MarkMcCaskey a=YaronWittenstein Part of the PR #807 changes was adding support for shared import objects between threads. https://github.com/wasmerio/wasmer/pull/807/files#diff-d20cb4c5a883566b85be4cc046f45aa9R49 I've added tests/examples on how to create an `import object` with a state_creator (function or closure) Co-authored-by: Yaron Wittenstein <[email protected]>
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 31, 2020
865: adding tests for `state_creator` of `import_object` r=syrusakbary a=YaronWittenstein Part of the PR #807 changes was adding support for shared import objects between threads. https://github.com/wasmerio/wasmer/pull/807/files#diff-d20cb4c5a883566b85be4cc046f45aa9R49 I've added tests/examples on how to create an `import object` with a state_creator (function or closure) Co-authored-by: Yaron Wittenstein <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Build failed |
|
This is no longer needed on the refactor. Adding the label so we can close quickly the PR after publishing the refactor. |
|
State creator is no longer supported in the import object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the PR #807 changes was adding support for shared import objects between threads.
https://github.com/wasmerio/wasmer/pull/807/files#diff-d20cb4c5a883566b85be4cc046f45aa9R49
I've added tests/examples on how to create an
import objectwith a state_creator(function or closure)