[fix issue #679] add details when calling unimplemented! #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pventuzelo
requested review from
bjfish,
Hywan,
MarkMcCaskey,
nlewycky and
syrusakbary
as code owners
MarkMcCaskey
approved these changes
Oct 3, 2019
|
i just fixed an error happening during |
MarkMcCaskey
approved these changes
Oct 7, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 23, 2019
861: [fix issue #679] add details when calling unimplemented! r=MarkMcCaskey a=pventuzelo # Description As discuss in issue #679, `unimplemented!` should provide a string to explain at least where the issue occurs. This pull request only add messages on existing `unimplemented!` and don't change any previous logics/behaviors in the code. # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Patrick Ventuzelo <[email protected]> Co-authored-by: Mark McCaskey <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discuss in issue #679,
unimplemented!should provide a string to explain at least where the issue occurs. This pull request only add messages on existingunimplemented!and don't change any previous logics/behaviors in the code.Review