Fix 830 panic unwrap wasmer args #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pventuzelo
requested review from
MarkMcCaskey and
syrusakbary
as code owners
syrusakbary
approved these changes
Sep 25, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 25, 2019
834: Fix 830 panic unwrap wasmer args r=syrusakbary a=pventuzelo # Description Fix issue #830 * Check for error from `parse()` before unwraping. # After the fix ``` sh ./target/release/wasmer run fib.wasm -- abc Error: Can't parse the provided argument "abc" as a integer ``` # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Patrick Ventuzelo <[email protected]> Co-authored-by: Patrick Ventuzelo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue #830
parse()before unwraping.After the fix
./target/release/wasmer run fib.wasm -- abc Error: Can't parse the provided argument "abc" as a integerReview