Fix issue 800 - check index before accessing imports.globals #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pventuzelo can you add the changes of this PR into the CHANGELOG.md? Once is done we should be ready to merge! |
pventuzelo
force-pushed
the
ventuzelo/fix-800-index-oob-backing
branch
from
4a47ea8 to
08665f7
Compare
|
@syrusakbary Done ;) |
syrusakbary
approved these changes
Sep 25, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 25, 2019
809: Fix issue 800 - check index before accessing imports.globals r=syrusakbary a=pventuzelo # Description Fix issue #800 * Check if `import_global_index` is valid i.e inside imports.globals range. * Related functions: * validate_memories * validate_tables * finalize_memories * finalize_tables # After the fix ``` sh $ ./target/release/wasmer run index_oob_LocalBacking_validate_memories_152.wasm execute_wasm: "Can\'t instantiate module: LinkError([Generic { message: \"incorrect global index for initializer\" }])" -------------------------------------------------------------------------------------------------------- $ ./target/release/wasmer run index_oob_LocalBacking_validate_tables_276.wasm execute_wasm: "Can\'t instantiate module: LinkError([Generic { message: \"incorrect global index for initializer\" }])" ``` # Review - [x] Create a short description of the the change in the CHANGELOG.md file Co-authored-by: Patrick Ventuzelo <[email protected]> Co-authored-by: Patrick Ventuzelo <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue #800
import_global_indexis valid i.e inside imports.globals range.After the fix
Review