Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use union merge on the changelog file. #788

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Conversation

nlewycky
Copy link
Contributor

@nlewycky nlewycky commented Sep 13, 2019

Description

This keeps both sides of a conflict. It's essentially the same as removing the
conflict markers.

Review

  • Create a short description of the the change in the CHANGELOG.md file

@nlewycky nlewycky force-pushed the feature/changelog-merge branch from 11ef1fb to d0f85cf Compare September 13, 2019 21:06
This keeps both sides of a conflict. It's essentially the same as removing the
conflict markers.
@nlewycky nlewycky force-pushed the feature/changelog-merge branch from d0f85cf to abd71aa Compare September 13, 2019 21:47
@nlewycky
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Sep 13, 2019
788: Use union merge on the changelog file. r=nlewycky a=nlewycky

# Description
This keeps both sides of a conflict. It's essentially the same as removing the
conflict markers.

# Review

- [x] Create a short description of the the change in the CHANGELOG.md file


Co-authored-by: Nick Lewycky <[email protected]>
@nlewycky
Copy link
Contributor Author

bors retry

@bors
Copy link
Contributor

bors bot commented Sep 13, 2019

Already running a review

@MarkMcCaskey
Copy link
Contributor

bors r-

@bors
Copy link
Contributor

bors bot commented Sep 13, 2019

Canceled

@MarkMcCaskey
Copy link
Contributor

bors retry

@MarkMcCaskey
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Sep 13, 2019
788: Use union merge on the changelog file. r=MarkMcCaskey a=nlewycky

# Description
This keeps both sides of a conflict. It's essentially the same as removing the
conflict markers.

# Review

- [x] Create a short description of the the change in the CHANGELOG.md file


Co-authored-by: Nick Lewycky <[email protected]>
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t know that was possible!

@bors
Copy link
Contributor

bors bot commented Sep 13, 2019

Build succeeded

  • wasmerio.wasmer

@bors bors bot merged commit abd71aa into master Sep 13, 2019
@bors bors bot deleted the feature/changelog-merge branch September 13, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants