Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement atomic load and store instructions with actual atomics in the LLVM backend. #786

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Implement atomic load and store instructions with actual atomics in the LLVM backend. #786

merged 2 commits into from
Sep 13, 2019

Conversation

nlewycky
Copy link
Contributor

@nlewycky nlewycky commented Sep 13, 2019 •
edited
Loading

Includes a run of cargo update to pick up the newer inkwell required.

Review

  • Create a short description of the the change in the CHANGELOG.md file

@nlewycky nlewycky requested a review from losfair as a code owner September 13, 2019 06:40
Hywan
Hywan approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Hywan Hywan self-assigned this Sep 13, 2019
@Hywan Hywan added 🎉 enhancement New feature! 📦 lib-compiler-llvm About wasmer-compiler-llvm labels Sep 13, 2019
@Hywan
Copy link
Contributor

Hywan commented Sep 13, 2019

Can you create the CHANGELOG entry please?

@nlewycky
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 13, 2019

Merge conflict (retrying...)

@bors
Copy link
Contributor

bors bot commented Sep 13, 2019

Merge conflict

@nlewycky
Implement atomic load and store instructions with actual atomics in t…
8dd82c0 
…he LLVM backend.

Includes a run of `cargo update` to pick up the newer inkwell required.
@nlewycky
Add changelog entry.
2eac9ac
@nlewycky nlewycky force-pushed the feature/llvm-atomics branch from 74fcf3c to 2eac9ac Compare September 13, 2019 19:06
@nlewycky
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 13, 2019

Merge conflict (retrying...)

bors bot added a commit that referenced this pull request Sep 13, 2019
@bors @nlewycky
Merge #786
8e17399 
786: Implement atomic load and store instructions with actual atomics in the LLVM backend. r=nlewycky a=nlewycky

Includes a run of `cargo update` to pick up the newer inkwell required.

# Review

- [x] Create a short description of the the change in the CHANGELOG.md file


Co-authored-by: Nick Lewycky <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 13, 2019

Build succeeded

  • wasmerio.wasmer

@bors bors bot merged commit 2eac9ac into master Sep 13, 2019
@bors bors bot deleted the feature/llvm-atomics branch September 13, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan approved these changes

@losfair losfair Awaiting requested review from losfair

Assignees

@Hywan Hywan

Labels
🎉 enhancement New feature! 📦 lib-compiler-llvm About wasmer-compiler-llvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlewycky @Hywan