-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy the spectest repository license from the official WebAssembly testsuite. These tests are under that license. #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
approved these changes
Sep 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree!
Can you create the |
syrusakbary
approved these changes
Sep 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved (subject to Changelog update)
bors r+ |
Merge conflict (retrying...) |
1 similar comment
Merge conflict (retrying...) |
Merge conflict |
…stsuite. These tests are under that license. Remove our own license statements on a few files since they're now redundant. They were all referencing this license.
nlewycky
force-pushed
the
nlewycky/spectest-license
branch
from
September 13, 2019 20:38
e928703
to
fd1b154
Compare
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 13, 2019
785: Copy the spectest repository license from the official WebAssembly testsuite. These tests are under that license. r=nlewycky a=nlewycky Remove our own license statements on a few files since they're now redundant. They were all referencing this license. Co-authored-by: Nick Lewycky <[email protected]>
Build succeeded
|
bors bot
added a commit
that referenced
this pull request
Sep 17, 2019
802: This is no longer referring to the correct line. r=nlewycky a=nlewycky It's supposed to be 352 which is already there. Three lines were deleted in #785. Co-authored-by: Nick Lewycky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove our own license statements on a few files since they're now redundant. They were all referencing this license.