Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasmer run can run text wat files, not webassembly spectest files. #784

Merged
merged 2 commits into from
Sep 13, 2019

Conversation

nlewycky
Copy link
Contributor

@nlewycky nlewycky commented Sep 13, 2019

Description

Correct an incorrect description of the wasmer run subcommand. It can't run webassembly spectest files (.wast), it can run webassembly text files (.wat).

Review

  • Create a short description of the the change in the CHANGELOG.md file

n/a

Copy link
Contributor

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Thanks!

@Hywan Hywan self-assigned this Sep 13, 2019
@Hywan Hywan added bug Something isn't working 📦 lib-cli About wasmer-cli labels Sep 13, 2019
@Hywan
Copy link
Contributor

Hywan commented Sep 13, 2019

Can you create the CHANGELOG entry please?

@nlewycky
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Sep 13, 2019
784: Wasmer run can run text wat files, not webassembly spectest files. r=nlewycky a=nlewycky

# Description
Correct an incorrect description of the `wasmer run` subcommand. It can't run webassembly spectest files (`.wast`), it can run webassembly text files (`.wat`).

# Review

- [x] Create a short description of the the change in the CHANGELOG.md file

n/a


Co-authored-by: Nick Lewycky <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 13, 2019

Build succeeded

  • wasmerio.wasmer

@bors bors bot merged commit c02f0cc into master Sep 13, 2019
@bors bors bot deleted the nlewycky/help-string-typo branch September 13, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📦 lib-cli About wasmer-cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants