Add test for closing wasi preopen fd #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
|
bors retry |
tryAlready running a review |
|
bors try- |
|
bors try |
tryBuild succeeded
|
nlewycky
approved these changes
Sep 11, 2019
lib/wasi/src/state/mod.rs
Outdated
| // calling `path_open` can give you an fd to the same inode as a preopen fd | ||
| entries.remove(&key); | ||
| self.preopen_fds.remove(i); | ||
| // Maybe recursively closes fds if og preopen? |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 11, 2019
776: Add test for closing wasi preopen fd r=MarkMcCaskey a=MarkMcCaskey As discussed in WASI, we should be able to close preopen fds Co-authored-by: Mark McCaskey <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in WASI, we should be able to close preopen fds