Add AArch64 support for singlepass. #713

losfair · 2019-08-22T20:07:01Z

This PR includes:

Support for AArch64 (ARM64) in Singlepass backend. Implemented with a combination of x86_64 instruction translation and native code generation.
State tracing and backtraces on AArch64/Singlepass. (Tiering is not implemented for this pair because there's no other backend supporting AArch64 yet)
Debugging tools: BlockTrace middleware, and support for reading states of previous WebAssembly stack frames from middlewares.

losfair · 2019-11-21T23:27:04Z

bors try

bors · 2019-11-22T00:03:49Z

try

Build failed

wasmerio.wasmer

losfair · 2019-11-22T00:08:26Z

bors try

bors · 2019-11-22T00:45:17Z

try

Build succeeded

wasmerio.wasmer

…aarch64

# Conflicts: # Makefile

… feature/singlepass-aarch64

losfair · 2019-11-22T16:02:16Z

bors try

bors · 2019-11-22T16:39:12Z

try

Build succeeded

wasmerio.wasmer

syrusakbary · 2019-11-22T18:24:41Z

bors r+

713: Add AArch64 support for singlepass. r=syrusakbary a=losfair This PR includes: - Support for AArch64 (ARM64) in Singlepass backend. Implemented with a combination of x86_64 instruction translation and native code generation. - State tracing and backtraces on AArch64/Singlepass. (Tiering is not implemented for this pair because there's no other backend supporting AArch64 yet) - Debugging tools: `BlockTrace` middleware, and support for reading states of previous WebAssembly stack frames from middlewares. Co-authored-by: losfair <[email protected]>

bors · 2019-11-22T18:59:55Z

Build succeeded

wasmerio.wasmer

MarkMcCaskey

Looks pretty good to me! Though a PR this long is very hard to review -- I ended up skipping most of the code generation and translation changes 🤷‍♂ ; it'd be nice if changes like this could be merged in with 10-20 PRs of reasonable size

lib/runtime-core/src/backend.rs

MarkMcCaskey · 2019-12-11T22:54:39Z

lib/runtime-core/src/fault.rs

        pub fn setjmp(env: *mut c_void) -> i32;
+        /// libc longjmp


We depend on libc in runtime-core; is there a reason we aren't using the libc version?

MarkMcCaskey · 2019-12-11T22:55:20Z

lib/runtime-core/src/fault.rs

 const TRAP_STACK_SIZE: usize = 1048576; // 1MB

-const SETJMP_BUFFER_LEN: usize = 27;
+const SETJMP_BUFFER_LEN: usize = 128;
 type SetJmpBuffer = [i32; SETJMP_BUFFER_LEN];


repinging on this

MarkMcCaskey · 2019-12-11T23:05:34Z

lib/runtime-core/src/fault.rs


    FaultInfo {
        faulting_addr: si_addr as usize as _,
-        ip: gregs[REG_RIP as usize] as _,
+        ip: std::mem::transmute::<&mut i64, &'static Cell<usize>>(&mut gregs[REG_RIP as usize]),


I think this can probably cause undefined behavior but it's pretty subtle. The fact that a normal type in Rust exists that is being accessed with Cell or UnsafeCell is unsound. Cell by way of UnsafeCell is the only way to have aliased mutability in Rust without undefined behavior. This code allows aliased mutability where one side may be a Rust type without Cell or UnsafeCell. I believe that is undefined behavior.

lib/runtime-core/src/state.rs

MarkMcCaskey · 2019-12-11T23:15:38Z

lib/singlepass-backend/src/codegen_x64.rs

+                        &mut self.machine,
+                        tmp_in,
+                        -1.0,
+                        18446744073709551616.0,


⛳️
u64::max_value() as f64 (if this is the same, then I think it's more readable)

MarkMcCaskey · 2019-12-11T23:17:30Z

src/bin/wasmer.rs

@@ -397,7 +403,7 @@ fn execute_wasm(options: &Run) -> Result<(), String> {
            .map_err(|e| format!("Can't convert from wast to wasm: {:?}", e))?;
    }

-    let compiler: Box<dyn Compiler> = match get_compiler_by_backend(options.backend) {
+    let compiler: Box<dyn Compiler> = match get_compiler_by_backend(options.backend, options) {


repinging on this

1068: Various cleanups for the singlepass backend on AArch64. r=losfair a=losfair ref: #713 Co-authored-by: losfair <[email protected]>

losfair force-pushed the feature/singlepass-aarch64 branch from 285d7e9 to e6c6705 Compare September 6, 2019 17:31

AArch64 translation module.

4210715

losfair force-pushed the feature/singlepass-aarch64 branch from e6c6705 to 4210715 Compare September 6, 2019 17:32

losfair added 9 commits September 11, 2019 01:13

Add impl for more instructions for aarch64 translator.

ce7c903

More instructions & aarch64 trampolines.

d3227f8

Relax constraints a bit to compile on aarch64.

9b77677

Fixed compilation on aarch64.

2af69f6

Temporarily disable all lints in runtime-core.

96163a0

Bump dynasm to v0.5.1

05557fc

Fix emit_lea.

d8b313e

Print return value from pure WASM binary.

574e4c4

Add homomorphic host redirection abstraction for vm->host calls.

b57aba4

losfair force-pushed the feature/singlepass-aarch64 branch from 9ab3da3 to b57aba4 Compare September 17, 2019 18:14

losfair added 7 commits September 18, 2019 02:21

Ensure callee-saved registers are properly preserved.

97b75d0

Add missing emit_mov variants.

e406005

Fix memory grow

72b6123

Fix return from homomorphic host redirection trampoline.

8a91f80

movzx/movsx

5f8b289

Fix Operator::MemorySize.

a124d87

Integer subset done.

3dadbc1

syrusakbary mentioned this pull request Sep 23, 2019

Wasmer on Raspberry Pi? #826

Closed

losfair added 9 commits September 28, 2019 17:31

Fixes for aarch64.

89d8b5a

More mov variants.

b304317

Implement get_fault_info for aarch64.

80d6c4c

Make state mapping work on non-x86 architectures.

e0e7d58

Move {push,pop}_code_version to caller side for non-mananged execution.

b5bb3fa

x

c337999

x

bd06aa0

Update a few examples.

3778352

Replace brk with undefined instruction.

8ee4b7f

Add 'fault' placeholder for Windows.

5da44c3

bors bot added a commit that referenced this pull request Nov 21, 2019

Try #713:

52a0c75

Skip push/pop code version on Windows.

ee7b0d6

bors bot added a commit that referenced this pull request Nov 22, 2019

Try #713:

66db8a6

losfair and others added 4 commits November 22, 2019 09:09

Merge remote-tracking branch 'origin/master' into feature/singlepass-…

87f4183

…aarch64

Merge branch 'master' into feature/singlepass-aarch64

0834ccf

# Conflicts: # Makefile

Try pinning Rust version for arm64 build.

21e6766

Merge remote-tracking branch 'origin/feature/singlepass-aarch64' into…

80fb5b4

… feature/singlepass-aarch64

bors bot added a commit that referenced this pull request Nov 22, 2019

Try #713:

2f6937b

syrusakbary added 2 commits November 22, 2019 09:49

Skip serializing on singlepass

a691d34

Make travis work only on test branches

183dd32

syrusakbary approved these changes Nov 22, 2019

View reviewed changes

wasmerio deleted a comment from bors bot Nov 22, 2019

bors bot merged commit 183dd32 into master Nov 22, 2019

bors bot deleted the feature/singlepass-aarch64 branch November 22, 2019 19:00

losfair mentioned this pull request Nov 23, 2019

Fix trap handler in WSL environment. #562

Closed

MarkMcCaskey mentioned this pull request Dec 11, 2019

Add ARM CI to bors's list #1055

Merged

MarkMcCaskey reviewed Dec 11, 2019

View reviewed changes

losfair mentioned this pull request Dec 16, 2019

Various cleanups for the singlepass backend on AArch64. #1068

Merged

bors bot added a commit that referenced this pull request Dec 17, 2019

Merge #1068

971f4e3

1068: Various cleanups for the singlepass backend on AArch64. r=losfair a=losfair ref: #713 Co-authored-by: losfair <[email protected]>

faddat mentioned this pull request Mar 18, 2021

Add support for ARM CosmWasm/wasmvm#53

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AArch64 support for singlepass. #713

Add AArch64 support for singlepass. #713

losfair commented Aug 22, 2019 •

edited

Loading

losfair commented Nov 21, 2019

bors bot commented Nov 22, 2019

losfair commented Nov 22, 2019

bors bot commented Nov 22, 2019

losfair commented Nov 22, 2019

bors bot commented Nov 22, 2019

syrusakbary commented Nov 22, 2019

bors bot commented Nov 22, 2019

MarkMcCaskey left a comment

MarkMcCaskey Dec 11, 2019

MarkMcCaskey Dec 11, 2019

MarkMcCaskey Dec 11, 2019

MarkMcCaskey Dec 11, 2019

MarkMcCaskey Dec 11, 2019

Add AArch64 support for singlepass. #713

Add AArch64 support for singlepass. #713

Conversation

losfair commented Aug 22, 2019 • edited Loading

losfair commented Nov 21, 2019

bors bot commented Nov 22, 2019

try

Build failed

losfair commented Nov 22, 2019

bors bot commented Nov 22, 2019

try

Build succeeded

losfair commented Nov 22, 2019

bors bot commented Nov 22, 2019

try

Build succeeded

syrusakbary commented Nov 22, 2019

bors bot commented Nov 22, 2019

Build succeeded

MarkMcCaskey left a comment

Choose a reason for hiding this comment

MarkMcCaskey Dec 11, 2019

Choose a reason for hiding this comment

MarkMcCaskey Dec 11, 2019

Choose a reason for hiding this comment

MarkMcCaskey Dec 11, 2019

Choose a reason for hiding this comment

MarkMcCaskey Dec 11, 2019

Choose a reason for hiding this comment

MarkMcCaskey Dec 11, 2019

Choose a reason for hiding this comment

losfair commented Aug 22, 2019 •

edited

Loading