Fix compilation on AArch64 Linux. #703
Merged
+36
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losfair
requested review from
bjfish,
MarkMcCaskey,
nlewycky and
syrusakbary
as code owners
losfair
force-pushed
the
fix/aarch64-compilation
branch
from
c40eba3 to
3f0dae3
Compare
| @@ -168,13 +168,13 @@ pub fn ___syscall38(ctx: &mut Ctx, _which: c_int, mut varargs: VarArgs) -> i32 { | |||
| debug!("emscripten::___syscall38 (rename)"); | |||
| let old_path = varargs.get_str(ctx); | |||
| let new_path = varargs.get_str(ctx); | |||
| let real_old_path_owned = get_cstr_path(ctx, old_path); | |||
| let real_old_path_owned = get_cstr_path(ctx, old_path as *const _); | |||
There was a problem hiding this comment.
I'm curious why this is an architecture specific issue 🤔
There was a problem hiding this comment.
Rust libstd for ARM (both 32 and 64) uses u8 instead of i8 in many places. I don't understand why though.
bjfish
approved these changes
Aug 21, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 21, 2019
703: Fix compilation on AArch64 Linux. r=losfair a=losfair This only fixes compilation. Cranelift still reports many `not yet implemented` on AArch64. Co-authored-by: losfair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only fixes compilation. Cranelift still reports many
not yet implementedon AArch64.