C api extract instance context from instance #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaronWittenstein
deleted the
c-api-extract-instance_context-from-instance
branch
YaronWittenstein
restored the
c-api-extract-instance_context-from-instance
branch
YaronWittenstein
deleted the
c-api-extract-instance_context-from-instance
branch
YaronWittenstein
restored the
c-api-extract-instance_context-from-instance
branch
bjfish
suggested changes
Aug 1, 2019
There was a problem hiding this comment.
This looks good, thanks. Please change a couple of things:
- The
lib/runtime-c-api/tests/test-contextbinary could be removed and the filename added to:lib/runtime-c-api/tests/.gitignore - Please add some usage of the new
wasmer_instance_context_getto thetest-context.ctest and some assertion to verify it works.
YaronWittenstein
force-pushed
the
c-api-extract-instance_context-from-instance
branch
from
9ba2619 to
3a84288
Compare
YaronWittenstein
commented
Aug 1, 2019
| assert(call1_result == WASMER_OK); | ||
|
|
||
| const wasmer_instance_context_t *ctx = wasmer_instance_context_get(instance); | ||
| counter_data *cd = (counter_data*)wasmer_instance_context_data_get(ctx); |
There was a problem hiding this comment.
@bjfish here is a usage for the new wasmer_instance_context_get
bjfish
approved these changes
Aug 1, 2019
|
Looks good, thanks! |
bors bot
added a commit
that referenced
this pull request
Aug 1, 2019
602: C api extract instance context from instance r=bjfish a=YaronWittenstein Here is an example of usage: https://github.com/spacemeshos/svm/blob/c9a9d56bd064ef18493f60082a5e38e561e1889d/crates/svm-wasmer-c-api/examples/counter.c#L132 Co-authored-by: Yaron Wittenstein <[email protected]>
YaronWittenstein
deleted the
c-api-extract-instance_context-from-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an example of usage:
https://github.com/spacemeshos/svm/blob/c9a9d56bd064ef18493f60082a5e38e561e1889d/crates/svm-wasmer-c-api/examples/counter.c#L132