Merged
Conversation
Needed for some of the tests to run.
theduke
force-pushed
the
run-821-build-update-webkit-dependency-flakenix
branch
from
4c571f6 to
47a0e87
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the webkit dependency from version 4.0 to 4.1 in the Nix flake configuration to enable certain tests to run properly.
- Updates webkit package from
webkitgtk_4_0towebkitgtk_4_1 - Modifies the flakeutils input structure to follow nixpkgs
- Changes nixpkgs input from pinned version to indirect reference
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| flake.nix | Updates webkit dependency to version 4.1 and restructures flake inputs |
| flake.lock | Updates nixpkgs lock with new revision and changes to indirect reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marxin
approved these changes
Dec 23, 2025
Contributor
|
This breaks the build: |
Twey
added a commit
to Twey/rusty_jsc
that referenced
this pull request
Mar 11, 2026
In wasmerio/wasmer#5999 Wasmer has moved its pinned version of `javascriptcoregtk` to 4.1 since 4.0 has reached end of life in nixpkgs. Unfortunately, that breaks this package, since 4.0 is no longer available in the environment. Let's update the expected version to 4.1.
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for some of the tests to run.
Fixes: #5998