Fix llvm backend failures in fat spec tests and simd_binaryen spec test. #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not handled here is @llvm.minnum and @llvm.maxnum which should be replaced with @llvm.minimum and @llvm.maximum, but using those currently leads to LLVM backend fatal errors.
…nd fatal error due to missing support for fminimum/fmaximum.
…ssues. This doesn't yet work as of this commit, we'll need to pick up a new version of wasmparser.rs too.
nlewycky
requested review from
losfair,
MarkMcCaskey and
syrusakbary
as code owners
|
bors r+ |
|
bors cancel |
bors bot
added a commit
that referenced
this pull request
Jul 30, 2019
599: Fix llvm backend failures in fat spec tests and simd_binaryen spec test. r=syrusakbary a=nlewycky Co-authored-by: Nick Lewycky <[email protected]> Co-authored-by: nlewycky <[email protected]>
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 31, 2019
599: Fix llvm backend failures in fat spec tests and simd_binaryen spec test. r=syrusakbary a=nlewycky Co-authored-by: Nick Lewycky <[email protected]> Co-authored-by: nlewycky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.