State preserving for LLVM, and Singlepass -> LLVM OSR-based tier switching. #567

losfair · 2019-07-17T18:44:10Z

No description provided.

lib/llvm-backend/src/code.rs

lib/llvm-backend/cpp/object_loader.cpp

lib/llvm-backend/src/backend.rs

lib/runtime-core/src/fault.rs

lib/runtime-core/src/state.rs

nlewycky · 2019-08-02T01:15:34Z

lib/runtime-core/src/state.rs

+                22 => X64Register::XMM(XMM::XMM5),
+                23 => X64Register::XMM(XMM::XMM6),
+                24 => X64Register::XMM(XMM::XMM7),
+                _ => return None,


This applies to LLVM generated code too, right? Any reason to believe LLVM will never use XMM8--XMM31? YMM? ZMM/K (AVX-512)? I'm willing to say that we will never use x87 floating point stack or MMX registers.

Good point. Will add XMM8-XMM31 in. Since all values tracked by the stack map are not larger than 64 bits (SIMD is an exception, but can fix it later), saving just XMM8-31 should be enough?

If it works then it's fine for now, but I can't promise that LLVM won't pack four 64-bit values together in a YMM register for example. It could if it wanted to, it just doesn't seem to want to.

What goes wrong if LLVM uses registers that aren't listed here? a) Will it cause problems at runtime or do we just realize we can't tier-switch at this point and ignore it? b) Is there a way I can test whether other registers are used, starting with a given Wasm file?

If the LLVM values "semantically" are at most 64 bits, then the equivalent runtime locations are unlikely to be larger than 64 bits - I don't think there's a way to represent in stackmap a value with different sizes between LLVM value and runtime location. Also, with the presence of stackmap some LLVM optimizations won't apply.

The compiler will panic if this function returns None, indicating a bug.

lib/singlepass-backend/src/codegen_x64.rs

lib/runtime-core/src/state.rs

lib/llvm-backend/src/code.rs

Does not handle long-running functions, but should work at least.

syrusakbary · 2019-08-09T08:08:34Z

@losfair @nlewycky I believe this might be useful when reviewing this PR:
https://github.com/wasmerio/wasmer/pull/298/files#diff-5ab40264a7ce86c159bf06530f13c3e1R9

lib/llvm-backend/src/backend.rs

…e area information is missing)

bors · 2019-08-22T20:45:24Z

try

Build failed

ci/circleci: test-stable

losfair · 2019-08-23T00:58:18Z

bors try

bors · 2019-08-23T01:08:59Z

try

Build failed

ci/circleci: test

losfair · 2019-08-23T02:02:12Z

bors try

bors · 2019-08-23T02:06:14Z

try

Build failed

ci/circleci: test-stable

losfair · 2019-08-23T06:15:02Z

bors try

bors · 2019-08-23T06:27:19Z

try

Build failed

ci/circleci: test-stable

losfair · 2019-09-01T10:00:27Z

bors try

bors · 2019-09-01T10:31:16Z

try

Build failed

wasmerio.wasmer

losfair · 2019-09-01T10:39:14Z

bors try

losfair · 2019-09-01T11:06:28Z

The failing Test linux test passes for me locally. Manually merging.

bors · 2019-09-01T11:24:15Z

try

Build failed

wasmerio.wasmer

Emit stack map at critical points.

a14a8e4

bjfish reviewed Jul 17, 2019

View reviewed changes

lib/llvm-backend/src/code.rs Outdated Show resolved Hide resolved

losfair added 8 commits July 19, 2019 02:02

Parsing LLVM stackmaps.

2e030c9

Populating LLVM stack maps into MSM/FSM.

0133b92

TwoHalves & trying to get cowsay to compile again

cc4f0e3

Stack parsing now works with LLVM.

efb5277

Allow a range of instruction offsets to be used in ip lookup.

0a7f95e

Add .clone() to fix singlepass.

283676a

Support runtime tier switching.

4f56703

Resolve semantics for more values.

9ed5094

nlewycky reviewed Aug 2, 2019

View reviewed changes

losfair added 5 commits August 7, 2019 00:06

Use setjmp/longjmp to handle LLVM exceptions.

b50fd31

Custom setjmp/longjmp to avoid SEH. (will it work?)

4b1d337

longjmp turns out to work on Windows. Remove custom unwinding code.

b113f5a

Commented out code for saving semantics of internal values.

0d604b7

Swap code lazily when tiering up from singlepass to LLVM.

c161902

Does not handle long-running functions, but should work at least.

losfair added 4 commits August 10, 2019 02:32

Refactor tier switching code

b8c1821

Enable managed feature in wasmer-runtime-core

8dfdd82

Add CLI option for optimized backends.

03665fe

Cargo fmt

2e89f02

losfair marked this pull request as ready for review August 9, 2019 18:45

losfair requested review from Hywan, MarkMcCaskey and syrusakbary as code owners August 9, 2019 18:45

bjfish reviewed Aug 9, 2019

View reviewed changes

lib/llvm-backend/src/backend.rs Show resolved Hide resolved

bjfish reviewed Aug 9, 2019

View reviewed changes

lib/llvm-backend/src/backend.rs Outdated Show resolved Hide resolved

bjfish reviewed Aug 9, 2019

View reviewed changes

lib/llvm-backend/src/backend.rs Outdated Show resolved Hide resolved

bjfish reviewed Aug 9, 2019

View reviewed changes

lib/llvm-backend/src/backend.rs Outdated Show resolved Hide resolved

Prevent continueing execution on unreliable stack. (LLVM register sav…

d61a8bb

…e area information is missing)

losfair added 3 commits August 22, 2019 17:22

Restore previous unwind_state.

f503764

Unblock signals in LLVM trap handler.

bdcd73c

Disable test_indirect_many as a mitigation for issue #717 .

dcb16a2

bors bot added a commit that referenced this pull request Aug 23, 2019

Try #567:

5d8fd7b

Fix LLVM object loader exceptions.

613e4de

bors bot added a commit that referenced this pull request Aug 23, 2019

Try #567:

c61b43c

Remove -fno-rtti

212e2be

bors bot added a commit that referenced this pull request Aug 23, 2019

Try #567:

3b57d79

Merge remote-tracking branch 'origin/master' into feature/llvm-osr

7dd5c92

losfair force-pushed the feature/llvm-osr branch from 30285f2 to 7dd5c92 Compare September 1, 2019 09:59

bors bot added a commit that referenced this pull request Sep 1, 2019

Try #567:

bf95fb7

losfair added 2 commits September 1, 2019 18:17

Fix the missing Copy trait error

4504065

Cargo fmt

9015b79

bors bot added a commit that referenced this pull request Sep 1, 2019

Try #567:

645a763

wasmerio deleted a comment from bors bot Sep 1, 2019

losfair merged commit c28b5d4 into master Sep 1, 2019

bors bot deleted the feature/llvm-osr branch September 1, 2019 11:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

State preserving for LLVM, and Singlepass -> LLVM OSR-based tier switching. #567

State preserving for LLVM, and Singlepass -> LLVM OSR-based tier switching. #567

losfair commented Jul 17, 2019

nlewycky Aug 2, 2019

losfair Aug 2, 2019

nlewycky Aug 20, 2019

losfair Aug 21, 2019

losfair Aug 21, 2019

syrusakbary commented Aug 9, 2019

bors bot commented Aug 22, 2019

losfair commented Aug 23, 2019

bors bot commented Aug 23, 2019

losfair commented Aug 23, 2019

bors bot commented Aug 23, 2019

losfair commented Aug 23, 2019

bors bot commented Aug 23, 2019

losfair commented Sep 1, 2019

bors bot commented Sep 1, 2019

losfair commented Sep 1, 2019

losfair commented Sep 1, 2019

bors bot commented Sep 1, 2019

State preserving for LLVM, and Singlepass -> LLVM OSR-based tier switching. #567

State preserving for LLVM, and Singlepass -> LLVM OSR-based tier switching. #567

Conversation

losfair commented Jul 17, 2019

nlewycky Aug 2, 2019

Choose a reason for hiding this comment

losfair Aug 2, 2019

Choose a reason for hiding this comment

nlewycky Aug 20, 2019

Choose a reason for hiding this comment

losfair Aug 21, 2019

Choose a reason for hiding this comment

losfair Aug 21, 2019

Choose a reason for hiding this comment

syrusakbary commented Aug 9, 2019

bors bot commented Aug 22, 2019

try

Build failed

losfair commented Aug 23, 2019

bors bot commented Aug 23, 2019

try

Build failed

losfair commented Aug 23, 2019

bors bot commented Aug 23, 2019

try

Build failed

losfair commented Aug 23, 2019

bors bot commented Aug 23, 2019

try

Build failed

losfair commented Sep 1, 2019

bors bot commented Sep 1, 2019

try

Build failed

losfair commented Sep 1, 2019

losfair commented Sep 1, 2019

bors bot commented Sep 1, 2019

try

Build failed