improve wasitest infra and fix fseek test #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
syrusakbary
approved these changes
Jul 15, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 15, 2019
563: improve wasitest infra and fix fseek test r=MarkMcCaskey a=MarkMcCaskey This PR: - fixes arg parsing from comments - fixes the mapdir test to have the native code doing the same thing - makes `wasitests-generate` output stdout/stderr by default - adds function to print stdout and stderr for a command if it fails - compiles wasm with size optimizations - strips generated wasm with `wasm-strip` This makes wasm module sizes go down from 1.7, 1.9Mb to ~60kb, 80kb. Preventing git bloat and reducing likely bottleneck of reading wasm modules from disk Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Timed out |
|
Merging manually, as tests passed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
wasitests-generateoutput stdout/stderr by defaultwasm-stripThis makes wasm module sizes go down from 1.7, 1.9Mb to ~60kb, 80kb. Preventing git bloat and reducing likely bottleneck of reading wasm modules from disk