-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasi filesystem rewrite + implementation of many syscalls #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCaskey
changed the title
implement wasi::readlink
wasi filesystem rewrite + implementation of many syscalls
Jul 19, 2019
bors try |
syrusakbary
reviewed
Jul 19, 2019
syrusakbary
reviewed
Jul 19, 2019
syrusakbary
reviewed
Jul 19, 2019
syrusakbary
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than small nits it looks great.
I was not able to come with other new tests cases that will help on coverage
This comment has been minimized.
This comment has been minimized.
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 19, 2019
555: wasi filesystem rewrite + implementation of many syscalls r=MarkMcCaskey a=MarkMcCaskey This lets the go compiler print its help text... The rest of symlink code to follow... This PR also does a major refactor of the file system code. So we'll have to add more tests to be sure we didn't break anything Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Mark McCaskey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the go compiler print its help text...
The rest of symlink code to follow...
This PR also does a major refactor of the file system code. So we'll have to add more tests to be sure we didn't break anything