make AppConfig.name optional in wasmer-config
#5305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wasmer-cli treats `AppConfig` objects without names as valid, but this behavior is not reflected in the `AppConfig` schema. This discrepancy caused issues when attempting to parse a "valid" `AppConfig` using the wasmer-config create command, as the name field was marked as required. This commit makes the `AppConfig.name` field optional, thereby allowing programs to successfully parse configurations without a name field.
syrusakbary
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wasmer-cli treats
AppConfigobjects without names as valid, butthis behavior is not reflected in the
AppConfigschema.This discrepancy caused issues when attempting to parse a "valid"
AppConfigas per the wasmer cli. Wasmer CLI injects a nameif it does not exist, so this issue is not seen. But as the name field was
marked as required, other clients using wasmer-config would fail.
Example app.yaml config that works with wasmer-cli but not with other clients:
This commit makes the
AppConfig.namefield optional, thereby allowingprograms to successfully parse configurations without a name field.