Pass readme content instead of readme file name #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the readme field in wasmer.toml is supposed to be a pathbuf, but it is being passed to the backend as a string. This should be the content of the readme file, and not the file path itself. the commit fixes this by reading the file, and passing the content correctly.
ayys
changed the title
xdoardo
approved these changes
Dec 10, 2024
syrusakbary
approved these changes
Dec 10, 2024
syrusakbary
reviewed
Dec 10, 2024
syrusakbary
requested changes
Dec 10, 2024
syrusakbary
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the readme field in wasmer.toml is supposed to be a pathbuf, but it is
being passed to the backend as a string. This should be the content
of the readme file, and not the file path itself.
the commit fixes this by reading the file, and passing the content
correctly.