Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alignment and padding of the WASIX snapshot type to align with wasix-libc #5259

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fix alignment and padding of the WASIX snapshot type to align with wasix-libc #5259

merged 2 commits into from
Nov 18, 2024
+77 −10

Conversation

Arshia001
Copy link
Member

This fixes the PHP crash when going through zend_catch.

@Arshia001
Copy link
Member Author

Incidentally, this fixes #3602.

maminrayej
maminrayej approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@maminrayej maminrayej left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use u64::MAX instead of the handwritten hex value to make it more readable, otherwise LGTM.

@Arshia001 Arshia001 marked this pull request as draft November 18, 2024 07:49
@Arshia001 Arshia001 marked this pull request as ready for review November 18, 2024 09:39
@Arshia001 Arshia001 enabled auto-merge November 18, 2024 11:24
@Arshia001 Arshia001 merged commit b122dfa into main Nov 18, 2024
71 of 72 checks passed
@Arshia001 Arshia001 deleted the fix/wasix-snapshot-padding branch November 18, 2024 11:27
@syrusakbary syrusakbary mentioned this pull request Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maminrayej maminrayej maminrayej approved these changes

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arshia001 @theduke @maminrayej